-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content bug: Sidebar "Related Topics" no longer shows any specific related topics on CSS pages #3827
Comments
@mdn/core-dev |
@AlpyneDreams See mdn/yari#3228 (cc @wbamberg) |
Ah, thanks. Will this issue have to move to yari or can it stay here? I maintain that this is still a problem, especially given the performance issues in mdn/yari#3332. |
@AlpyneDreams It can stay here (at least for now). |
I'm sorry you find the new sidebar less useful. Since I'm responsible for the changes perhaps I should try to explain some of my reasoning. This is largely going to be a rehash of https://discourse.mozilla.org/t/css-sidebar-proposal/49500, but I'll mostly stick to the usability issues and not the internal complexity). I agree that there are some places where the old sidebar did give you a useful set of related properties, and The old CSS sidebar gave you links to the items that belonged in the same CSS module. If the module to which an item belongs does not map cleanly to a group of related items, which is often the case, then the sidebar wasn't useful, and there are many cases like this. For example:
But aside from that, and whether or not your current module was actually a useful set of properties, the old sidebar was brittle: if you needed to navigate from the properties in your current module to another property (e.g. So those are the main problems that the new sidebar tries to address. I do agree it's a shame that in many cases the old sidebar gave easy access to some closely related properties, and now this is a bit harder. I think this is a tradeoff to address the other problems outlined above. We could perhaps keep the old "related-items-in-this-module" bit in the sidebar, and have the "everything" sidebar under it:
There are a couple of things I don't like about this. First it keeps all the complexity and fragility of the old sidebar, and adds some more. Second, which I care about more: I really like it when sidebars stay the same when you navigate. I think this helps people learn how to find things, and generally makes things behave in a more predictable way. But maybe I'm wrong about this! An alternative which I think would help would be for the sidebar to expand the section that contains the current page, and scroll to make the current item visible. So for example if you were on This means, at least, that if you were at Or maybe I'm just wrong, and we should revert the change 🤷. |
@wbamberg IMO FWIW
You suggested "We could perhaps keep the old "related-items-in-this-module" bit in the sidebar, and have the "everything" sidebar under it". |
I do very much agree with this principle but I think that the number of properties in CSS means that getting a strong mental model of a single sidebar is a lot harder, so I'm not sure the consistency is as beneficial as it would be were there significantly less stuff to index. I think you could get away with sticking a Related Topics section on top of the full sidebar as you suggest without breaking consistency as much by either by making it collapsible, or putting some sort of line between the two sections, something like that. (I agree with @hamishwillee's perspective about this idea too) Alternatively, I think this might be a good excuse to expand the function of the "See Also" section, which is often not very detailed.
|
Also,
While this was definitely an issue, I'd argue that the problem with |
What is the problem?
Many CSS pages used to have specific related topics in the sidebar listed under "Related Topics". Generally topics from a certain category (like "Fonts", " Box Model", etc) would get all the related pages from that category.
Now it simply displays the entire table of contents for the whole section of MDN: it lists every single CSS topic, every property, etc., even though the heading still says "Related Topics". Many of the links that were previously listed under Related Topics are now hard to find in these giant alphabetical lists, if they're even present.
Example: (click to open images)
Notice how previously the "Related Topics" were actually related to the specific topic, and now every single topic is listed instead.
What did you expect to see?
I personally found the related links to be very useful in using MDN, and I think they should still be included, even if this was intentional (I have no idea if it was), surely it would be better to still include the specific related topics above the rest of the table of contents?
Alternatively, these links could go under "See also", but there might be some redundancy with what's already there, and there are typically fewer links under "See also" than under "Related Topics"
I believe the change may have something to do with PR #3165 (fixing issue #3025), but I can't find the exact change made for the examples I'm providing as it is a very large PR.
Other possibly relevant issues:
What page(s) did you find the problem on?
Specific page section or heading?
In the sidebar or subnav, under "Related Topics" (class is
sidebar-quicklinks
). I've only noticed it on CSS pages however it may affect other sections too.Did you test this? If so, how?
N/A
Edit 1: Minor formatting tweaks.
Edit 2: Add note about "See also"
The text was updated successfully, but these errors were encountered: