Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menus.OnClickedData.srcUrl returns raw src value #10214

Merged

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Nov 1, 2021

Summary

Addresses the changes made in the return value of menus.OnClickedData.srcUrl including:

*updated release notes

  • clarification of menus.OnClickedData.srcUrl

Supporting note in compatibility data provided in menus.OnClickedData.srcUrl returned post-redirect URL #13259.

Supporting details

Addresses changes made in Bug 1659155.

Metadata

This PR…

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@rebloor rebloor added the Content:WebExt WebExtensions docs label Nov 1, 2021
@rebloor rebloor requested a review from Rob--W November 1, 2021 18:08
@rebloor rebloor self-assigned this Nov 1, 2021
@rebloor rebloor requested review from a team as code owners November 1, 2021 18:08
@rebloor rebloor requested review from ddbeck and removed request for a team November 1, 2021 18:08
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Nov 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2021

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/94
Title: Firefox 94 for developers
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/HTMLElement/enterkeyhint

External URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus/OnClickData
Title: menus.OnClickData
on GitHub

No new external URLs


URL: /en-US/docs/Mozilla/Firefox/Releases/94
Title: Firefox 94 for developers
on GitHub

No new external URLs

(this comment was updated 2021-11-04 15:07:15.906645)

Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The focus of this PR is incorrect; it should not be about emphasizing that it's <img src>, but stating that it's the src URL of an element (i.e. the initially requested URL, even if redirected). It's fine to list examples (as I did below), but the main point is to emphasize that the initial URL is used even if redirected.

@rebloor rebloor requested a review from Rob--W November 3, 2021 15:33
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ but clarify the difference and add bug reference.

files/en-us/mozilla/firefox/releases/94/index.md Outdated Show resolved Hide resolved
@rebloor rebloor changed the title menus.OnClickedData.srcUrl returns <img src> menus.OnClickedData.srcUrl returns raw src value Nov 3, 2021
Co-authored-by: Rob Wu <rob@robwu.nl>
@rebloor rebloor merged commit 3d8b935 into mdn:main Nov 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants