New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
menus.OnClickedData.srcUrl returns raw src value #10214
menus.OnClickedData.srcUrl returns raw src value #10214
Conversation
Preview URLs
FlawsNote! 1 document with no flaws that don't need to be listed. 🎉 URL:
External URLsURL: No new external URLs URL: No new external URLs (this comment was updated 2021-11-04 15:07:15.906645) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The focus of this PR is incorrect; it should not be about emphasizing that it's <img src>
, but stating that it's the src
URL of an element (i.e. the initially requested URL, even if redirected). It's fine to list examples (as I did below), but the main point is to emphasize that the initial URL is used even if redirected.
files/en-us/mozilla/add-ons/webextensions/api/menus/onclickdata/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ but clarify the difference and add bug reference.
Co-authored-by: Rob Wu <rob@robwu.nl>
Summary
Addresses the changes made in the return value of
menus.OnClickedData.srcUrl
including:*updated release notes
menus.OnClickedData.srcUrl
Supporting note in compatibility data provided in menus.OnClickedData.srcUrl returned post-redirect URL #13259.
Supporting details
Addresses changes made in Bug 1659155.
Metadata
This PR…