Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edits for clarity: aria-brailleroledescription #11734

Merged
merged 2 commits into from Jan 11, 2022
Merged

Edits for clarity: aria-brailleroledescription #11734

merged 2 commits into from Jan 11, 2022

Conversation

estelle
Copy link
Member

@estelle estelle commented Jan 4, 2022

Reread the page and made some edits along the way. No major content changes.

@estelle estelle requested a review from a team as a code owner January 4, 2022 23:42
@estelle estelle requested review from ericwbailey and removed request for a team January 4, 2022 23:42
@netlify
Copy link

netlify bot commented Jan 4, 2022 •
edited

✔️ Deploy Preview for mdn-contributor canceled.

🔨 Explore the source changes: c966671

🔍 Inspect the deploy log: https://app.netlify.com/sites/mdn-contributor/deploys/61d4db7f0424d60008972ddc

@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Jan 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022 •
edited

Preview URLs

Flaws

URL: /en-US/docs/web/Accessibility/ARIA/Attributes/aria-brailleroledescription
Title: aria-brailleroledescription
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Accessibility/ARIA/roles/generic_role

External URLs

URL: /en-US/docs/web/Accessibility/ARIA/Attributes/aria-brailleroledescription
Title: aria-brailleroledescription
on GitHub

No new external URLs

(this comment was updated 2022-01-10 22:40:47.936847)

@estelle @sideshowbarker
Apply suggestions from code review
83e4166 
Co-authored-by: Michael[tm] Smith <mike@w3.org>
@sideshowbarker sideshowbarker merged commit 5c42661 into mdn:main Jan 11, 2022
@estelle estelle deleted the brdEdits branch August 19, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@ericwbailey ericwbailey Awaiting requested review from ericwbailey ericwbailey is a code owner automatically assigned from mdn/yari-content-accessibility

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@estelle @sideshowbarker