Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window/isSecureContext→WindowOrWorkerGlobalScope/isSecureContext, and update spec URL #1228

Closed
wants to merge 1 commit into from

Conversation

sideshowbarker
Copy link
Collaborator

Fixes #1192

@sideshowbarker sideshowbarker requested a review from a team as a code owner January 12, 2021 17:04
@sideshowbarker sideshowbarker requested review from jpmedley and removed request for a team January 12, 2021 17:04
@domenic
Copy link
Contributor

domenic commented Jan 12, 2021

It still seems a bit weird that the page URL is Window/isSecureContext and it talks about the window.isSecureContext API. I'd have expected it to be more like https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/origin

@sideshowbarker
Copy link
Collaborator Author

sideshowbarker commented Jan 12, 2021

It still seems a bit weird that the page URL is Window/isSecureContext and it talks about the window.isSecureContext API. I'd have expected it to be more like developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/origin

Good point. I’ll update the patch to move it (along with adding a redirect) — and also change it in the body of the article.

@sideshowbarker
Copy link
Collaborator Author

Well it turns out we do already have https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/isSecureContext — so I’ll make the updates there instead, and just change https://developer.mozilla.org/en-US/docs/Web/API/Window/isSecureContext to a redirect to that.

@sideshowbarker sideshowbarker requested a review from a team as a code owner January 13, 2021 02:12
@sideshowbarker sideshowbarker requested review from chrisdavidmills and removed request for a team January 13, 2021 02:12
@sideshowbarker
Copy link
Collaborator Author

@domenic updates pushed — please re-review

@sideshowbarker sideshowbarker changed the title Note isSecureContext available to workers Redirect Window/isSecureContext to WindowOrWorkerGlobalScope/isSecureContext, and update spec URL (now in HTML spec) Jan 13, 2021
@sideshowbarker sideshowbarker changed the title Redirect Window/isSecureContext to WindowOrWorkerGlobalScope/isSecureContext, and update spec URL (now in HTML spec) Window/isSecureContext→WindowOrWorkerGlobalScope/isSecureContext, and update spec URL Jan 13, 2021
@sideshowbarker
Copy link
Collaborator Author

@domenic friendly ping

Copy link
Contributor

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!!

@sideshowbarker
Copy link
Collaborator Author

@jpmedley, @chrisdavidmills This is an easy review that’s already gotten a domain-expert OK but I guess hadn’t been merged yet just due to having merge conflicts. I resolved the conflicts, so it should now be ready for review/merging

@chrisdavidmills
Copy link
Contributor

The trouble I have with this PR is that @Elchi3 is currently working on removing all mixin content from MDN, and instead creating pages hanging off the the objects that the mixin-defined properties are actually access from, as it will be a lot less confusing for readers.

So Florian, is this change helpful in terms of housekeeping for the mixing work, or should we leave this page where it is?

@Elchi3
Copy link
Member

Elchi3 commented Feb 24, 2021

Thanks for the ping, Chris!

Yeah, so the current idea is to get rid of WindowOrWorkerGlobalScope and other mixin friends because these aren't real things to web developers. Please read more about it at #1940 (feedback welcome)

WindowOrWorkerGlobalScope is a bit special so we've started thinking about it here: #2427

I think this PR should be closed as it will be solved with #2427

@sideshowbarker
Copy link
Collaborator Author

OK, closing per #1228 (comment)

@sideshowbarker sideshowbarker deleted the sideshowbarker/isSecureContext branch February 24, 2021 12:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "Window.isSecureContext": …
4 participants