Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change browser-compat for individual input types #16085

Merged
merged 1 commit into from May 15, 2022
Merged

Change browser-compat for individual input types #16085

merged 1 commit into from May 15, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR updates the BCD keys for the individual input types of the <input> HTML element to match the changes in mdn/browser-compat-data#16295.

@queengooborg queengooborg requested a review from a team as a code owner May 15, 2022 21:37
@queengooborg queengooborg requested review from estelle and removed request for a team May 15, 2022 21:37
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label May 15, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/HTML/Element/input/password
Title: <input type="password">
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/selectionStart does not exist
    • /en-US/docs/Web/API/HTMLInputElement/selectionEnd does not exist
    • /en-US/docs/Web/API/HTMLInputElement/selectionDirection does not exist
  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_password

URL: /en-US/docs/Web/HTML/Element/input/url
Title: <input type="url">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_url

URL: /en-US/docs/Web/HTML/Element/input/search
Title: <input type="search">
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist
  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_search

URL: /en-US/docs/Web/HTML/Element/input/month
Title: <input type="month">
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist
  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_month

URL: /en-US/docs/Web/HTML/Element/input/number
Title: <input type="number">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_number

URL: /en-US/docs/Web/HTML/Element/input/date
Title: <input type="date">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_date

URL: /en-US/docs/Web/HTML/Element/input/datetime-local
Title: <input type="datetime-local">
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Element/input/datetime
  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_datetime-local

URL: /en-US/docs/Web/HTML/Element/input/radio
Title: <input type="radio">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_radio

URL: /en-US/docs/Web/HTML/Element/input/image
Title: <input type="image">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_image

URL: /en-US/docs/Web/HTML/Element/input/time
Title: <input type="time">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_time

URL: /en-US/docs/Web/HTML/Element/input/text
Title: <input type="text">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_text

URL: /en-US/docs/Web/HTML/Element/input/file
Title: <input type="file">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_file

URL: /en-US/docs/Web/HTML/Element/input/hidden
Title: <input type="hidden">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_hidden

URL: /en-US/docs/Web/HTML/Element/input/button
Title: <input type="button">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_button

URL: /en-US/docs/Web/HTML/Element/input/week
Title: <input type="week">
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist
  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_week

URL: /en-US/docs/Web/HTML/Element/input/email
Title: <input type="email">
on GitHub
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Attributes/list
    • Can't resolve /en-US/docs/Web/HTML/Attributes/list
    • Can't resolve /en-US/docs/Web/HTML/Attributes/placeholder
  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_email

URL: /en-US/docs/Web/HTML/Element/input/color
Title: <input type="color">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_color

URL: /en-US/docs/Web/HTML/Element/input/checkbox
Title: <input type="checkbox">
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/ValidityState/valueMissing does not exist
  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_checkbox

URL: /en-US/docs/Web/HTML/Element/input/submit
Title: <input type="submit">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_submit

URL: /en-US/docs/Web/HTML/Element/input/tel
Title: <input type="tel">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_tel

URL: /en-US/docs/Web/HTML/Element/input/reset
Title: <input type="reset">
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_reset

URL: /en-US/docs/Web/HTML/Element/input/range
Title: <input type="range">
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/valueAsNumber does not exist
  • bad_bcd_queries:
    • No BCD data for query: html.elements.input.type_range

External URLs

URL: /en-US/docs/Web/HTML/Element/input/password
Title: <input type="password">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/url
Title: <input type="url">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/search
Title: <input type="search">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/month
Title: <input type="month">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/number
Title: <input type="number">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/date
Title: <input type="date">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/datetime-local
Title: <input type="datetime-local">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/radio
Title: <input type="radio">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/image
Title: <input type="image">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/time
Title: <input type="time">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/text
Title: <input type="text">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/file
Title: <input type="file">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/hidden
Title: <input type="hidden">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/button
Title: <input type="button">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/week
Title: <input type="week">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/email
Title: <input type="email">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/color
Title: <input type="color">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/checkbox
Title: <input type="checkbox">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/submit
Title: <input type="submit">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/tel
Title: <input type="tel">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/reset
Title: <input type="reset">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/range
Title: <input type="range">
on GitHub

No new external URLs

hamishwillee
hamishwillee approved these changes May 15, 2022
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@queengooborg This looks excellent, but do we need to time this inclusion? I mean, this will break the pages if the BCD update is not already updated in MDN, and waiting too long will also break the pages.

Or is it just a matter of we include now and wait for BCD to catch up, because we can't really plan this?

@queengooborg
Copy link
Collaborator Author

Due to the difference in release timing between MDN content and BCD, I don't think this is something we can really properly plan -- either way, we'll have a small period of time where the tables are broken. I'd say that we should merge both PRs now and then let anyone who reports an issue know it'll automatically resolve within the week!

@hamishwillee hamishwillee merged commit 4a73f11 into mdn:main May 15, 2022
@hamishwillee
Copy link
Collaborator

@queengooborg Fair enough! Merged this one.

@queengooborg queengooborg deleted the input-element/types branch May 15, 2022 23:21
hamishwillee pushed a commit to hamishwillee/content that referenced this pull request May 23, 2022
@queengooborg @hamishwillee
Change browser-compat for individual input types (mdn#16085)
3fe02f2
This was referenced Aug 21, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-html

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@queengooborg @hamishwillee