Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window.open() rework #18118

Merged
merged 7 commits into from
Jul 19, 2022
Merged

Window.open() rework #18118

merged 7 commits into from
Jul 19, 2022

Commits on Jul 8, 2022

  1. first pass linting: remove xref macros, fix examples, fix code words

    @SphinxKnight
    SphinxKnight committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    5d64cfd View commit details
    Browse the repository at this point in the history

  2. 2nd pass: remove broken/insecure links, fix remaining typos

    @SphinxKnight
    SphinxKnight committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    5f7cb36 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Third pass - rework

    @SphinxKnight
    SphinxKnight committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    ec1f000 View commit details
    Browse the repository at this point in the history

  2. fix flaws

    @SphinxKnight
    SphinxKnight committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    d65b4a7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into window-open-overhaul

    @SphinxKnight
    SphinxKnight committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    85d50e6 View commit details
    Browse the repository at this point in the history

  4. Apply 1st set of suggestions 

    Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
    @SphinxKnight @teoli2003
    SphinxKnight and teoli2003 committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    2a25b3e View commit details
    Browse the repository at this point in the history

  5. Taking @teoli2003 review into account

    @SphinxKnight
    SphinxKnight committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    02a3742 View commit details
    Browse the repository at this point in the history