-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate MathML attributes scriptmize and scriptsizemultiplier #18273
Conversation
Preview URLs
FlawsNone! 🎉 External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2022-07-21 12:15:52.532999) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(More of a question)
- Starting with Gecko 29.0 {{geckoRelease("29.0")}}, the attributes accepted on the `<mstyle>` element have been restricted to those actually used in practice: `id, class, style, href, mathcolor, mathbackground, scriptlevel, displaystyle, scriptsizemultiplier, scriptminsize, dir, mathsize, mathvariant, fontfamily, fontweight, fontstyle, fontsize, color, background`. | ||
|
||
- Starting with Gecko 103.0 {{geckoRelease("103.0")}}, support for attributes `scriptsizemultiplier` and `scriptminsize` has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we have mdn/browser-compat-data for this?
It would be nice to add a Specifications and a Browser_compatibility page like we do for the rest of MDN.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess yes, probably.... But I guess there is a lot of of MathML data to update on mdn/browser-compat-data, this PR is just a first step to make clear these are deprecated...
(Incidentally, I don't know whether we can do "supported in XXX under a flag" or "removed in XXX since version YYY" which we will probably need)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like https://github.com/mdn/browser-compat-data/blob/main/mathml/elements/mstyle.json has some data already, let's add the section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmh, and Specifications and a Browser_compatibility sections are already present above actually (try to show more context). These Gecko-specific notes are very long...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@queengooborg I think these notes (https://pr18273.content.dev.mdn.mozit.cloud/en-US/docs/Web/MathML/Element/mstyle#gecko-specific_notes ) should be in bcd. Any advice on how to format/list them?
@fred-wang We try to avoid notes in Browser compat section nowadays (we don't succeed at 100% but we did some progress…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, browser compatibility data should definitely be placed in BCD rather than on the pages itself. There is a lot of information in these notes, some of which could be applied to existing subfeatures (scriptminsize
and scriptsizemultiplier
). I think that some of these should be split into multiple statements with partial_implementation
in BCD, for example the first note about lack of complete implementation before Firefox 6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the notes from MDN and open mdn/browser-compat-data#17043 for BCD.
38915e9
to
68f6098
Compare
2b7ff2c
to
5d98f0c
Compare
Also remove Gecko-specific notes, moved to browser-compat-data.
5d98f0c
to
a8d9e0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Summary
Deprecate MathML attributes scriptmize and scriptsizemultiplier and document change in Firefox 103.
Motivation
These attributes have been removed from Firefox 103, not implemented in any other browsers and not part of MathML Core.
Supporting details
https://bugzilla.mozilla.org/show_bug.cgi?id=1772697
https://w3c.github.io/mathml-core/#style-change-mstyle
Related issues
Metadata