Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: run pretteier on web/css batch 2 #20692

Merged
merged 5 commits into from Sep 25, 2022
Merged

Conversation

nschonni
Copy link
Contributor

Skipped some more that formatting broke the intention of the code

@nschonni nschonni requested a review from a team as a code owner September 13, 2022 19:27
@nschonni nschonni requested review from estelle and removed request for a team September 13, 2022 19:27
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Sep 13, 2022
@github-actions

This comment was marked as resolved.

@@ -20,7 +20,7 @@ The **`:-moz-suppressed`** [CSS](/en-US/docs/Web/CSS) [pseudo-class](/en-US/docs
## Syntax

```css
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```css
```css-nolint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this makes sense, but I'll leave it for a larger pass like was done for the javascript ones

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few places where the original is better than the edit.

There are also a lot of not-so-good HTML examples, that I'll edit after this is pushed..

files/en-us/web/css/_colon_active/index.md Show resolved Hide resolved
<button class="button with-fallback" type="button">
Button with fallback
</button>
<button class="button with-fallback" type="button">Button with fallback</button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

original is better.

</label></p>
<p>
<label
>Favorite animal:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

41/42 should be on the same line.

(element) => `#${element.getAttribute('id')}`,
).join(', ');
document.getElementById("results").innerHTML = Array.prototype.map
.call(selected, (element) => `#${element.getAttribute("id")}`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i find the original much easier to read

<li><a href="#p2">Jump to the second paragraph!</a></li>
<li>
<a href="#nowhere"
>This link goes nowhere, because the target doesn't exist.</a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ick.

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made code suggestions for the ones i actually care about.
The others aren't hills I want this PR to sleep on.
The button example: either both on 3 lines or both on 1 line, but they should match.

nschonni and others added 5 commits September 20, 2022 18:34
Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>
Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>
Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@estelle estelle merged commit 0dca7cc into mdn:main Sep 25, 2022
@nschonni nschonni deleted the prettier-web-css-2 branch September 25, 2022 16:56
himanshugarg pushed a commit to himanshugarg/content that referenced this pull request Sep 27, 2022
* style: run pretteier on web/css

* remove syntax formatting

Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>

* Update files/en-us/web/css/_colon_-moz-user-disabled/index.md

Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>

* fix: comment before selector

Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>

Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants