New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: run pretteier on web/css batch 2 #20692
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
@@ -20,7 +20,7 @@ The **`:-moz-suppressed`** [CSS](/en-US/docs/Web/CSS) [pseudo-class](/en-US/docs | |||
## Syntax | |||
|
|||
```css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```css | |
```css-nolint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this makes sense, but I'll leave it for a larger pass like was done for the javascript ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few places where the original is better than the edit.
There are also a lot of not-so-good HTML examples, that I'll edit after this is pushed..
<button class="button with-fallback" type="button"> | ||
Button with fallback | ||
</button> | ||
<button class="button with-fallback" type="button">Button with fallback</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
original is better.
</label></p> | ||
<p> | ||
<label | ||
>Favorite animal: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
41/42 should be on the same line.
(element) => `#${element.getAttribute('id')}`, | ||
).join(', '); | ||
document.getElementById("results").innerHTML = Array.prototype.map | ||
.call(selected, (element) => `#${element.getAttribute("id")}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i find the original much easier to read
<li><a href="#p2">Jump to the second paragraph!</a></li> | ||
<li> | ||
<a href="#nowhere" | ||
>This link goes nowhere, because the target doesn't exist.</a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made code suggestions for the ones i actually care about.
The others aren't hills I want this PR to sleep on.
The button example: either both on 3 lines or both on 1 line, but they should match.
Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>
Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>
Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
5b48d21
to
1af79f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
* style: run pretteier on web/css * remove syntax formatting Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com> * Update files/en-us/web/css/_colon_-moz-user-disabled/index.md Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com> * fix: comment before selector Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com> Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Skipped some more that formatting broke the intention of the code