Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contenteditable to define plaintext-only state #21875

Merged
merged 7 commits into from Jun 20, 2023
Merged

Update contenteditable to define plaintext-only state #21875

merged 7 commits into from Jun 20, 2023

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Oct 27, 2022 •
edited

Description

Adds plaintext-only value description for use with the contenteditable attribute.

Motivation

Bocoup is currently working on standardizing contenteditable=plaintext-only.

Additional details

Related issues and pull requests

@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs labels Oct 27, 2022
@Josh-Cena Josh-Cena added the on hold Waiting on something else before this can be moved forward. label Oct 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2022 •
edited

Preview URLs

(comment last updated: 2023-06-20 13:43:22)

@Josh-Cena
Copy link
Member

While we're at it, we should work to address #22048 and add the other missing values as well.

@bsmth
Copy link
Member

bsmth commented Jun 15, 2023

Hi @howard-e, thanks a lot for the submission. There's an unaddressed comment above, do you plan to come back to this one? Thanks :)

@howard-e
Copy link
Contributor Author

howard-e commented Jun 15, 2023 •
edited

There's an unaddressed comment above, do you plan to come back to this one?

Hi @bsmth, I would like to! But unfortunately, I don't have the capacity to do the related spec work at this time. I'd rather to leave that assignment open to any others that may be able to (or I can follow up in the future, otherwise)

And apologies @Josh-Cena, I must have missed your comment in my inbox at the time!

Additionally, since the related spec PRs have been merged, who can I request a review from or will this remain on hold until the other values are addressed? Or can we address those in separate PRs?

@howard-e howard-e marked this pull request as ready for review June 15, 2023 17:14
@howard-e howard-e requested review from a team as code owners June 15, 2023 17:14
@howard-e howard-e requested review from Elchi3 and estelle and removed request for a team June 15, 2023 17:14
@Josh-Cena
Copy link
Member

It's okay if you are unavailable to fill out the other values. We'll just wait for the assigned reviewers or someone else (probably not me) to approve the current change.

Elchi3
Elchi3 approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @howard-e 👍

@Elchi3 Elchi3 merged commit 6705ba5 into mdn:main Jun 20, 2023
6 checks passed
behnammodi pushed a commit to behnammodi/content that referenced this pull request Jun 26, 2023
@howard-e @queengooborg
@Josh-Cena @Elchi3 @behnammodi
Update contenteditable to define plaintext-only state (mdn#21875)
1637d09 
* Update contenteditable to define plaintext-only state

* Update files/en-us/web/api/htmlelement/contenteditable/index.md

---------

Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <vinyldarkscratch@gmail.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@Elchi3 Elchi3 Elchi3 approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-html

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs on hold Waiting on something else before this can be moved forward.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@howard-e @Josh-Cena @bsmth @Elchi3 @queengooborg