Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra call to counter.start() in example in WeakRef doc #2201

Merged
merged 1 commit into from Feb 10, 2021
Merged

Remove extra call to counter.start() in example in WeakRef doc #2201

merged 1 commit into from Feb 10, 2021

Conversation

masak
Copy link
Contributor

@masak masak commented Feb 9, 2021

This call is already made from the constructor, so we don't need to do it from the mainline code.

@masak
Remove extra call to counter.start()
5dc4a38 
This call is already made from the constructor, so we don't need to do it from the mainline code.
@masak masak requested a review from a team as a code owner February 9, 2021 09:35
@masak masak requested review from sideshowbarker and removed request for a team February 9, 2021 09:35
@sideshowbarker sideshowbarker changed the title Remove extra call to counter.start() Remove extra call to counter.start() in example in WeakRef doc Feb 10, 2021
@sideshowbarker sideshowbarker merged commit 5829e69 into mdn:main Feb 10, 2021
@sideshowbarker
Copy link
Collaborator

Carl, Thanks much, and congrats on landing your first docs change here — welcome aboard 🎉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masak @sideshowbarker