Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requestFullScreen - make transient user activation obvious #22387

Closed
wants to merge 1 commit into from

Conversation

hamishwillee
Copy link
Collaborator

Issue #22303 states that transient user activation is not mentioned. That is incorrect - but it clearly isn't visible enough or the issue wouldn't have been posted.

I have moved it to the description. @foolip - work for you?

Fixes #22303

@hamishwillee hamishwillee requested a review from a team as a code owner November 18, 2022 00:59
@hamishwillee hamishwillee requested review from Elchi3 and removed request for a team November 18, 2022 00:59
@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 18, 2022
@github-actions
Copy link
Contributor

@Elchi3
Copy link
Member

Elchi3 commented Nov 18, 2022

I introduced a "Security" section in #20435 and applied it consistently throughout API docs that require user activation. I think the real bug here is how to better display security requirements and I'm not sure this one off fix is addressing it. It certainly doesn't help with consistency in the docs.

#20435 also contains some more discussion on this but it hasn't been followed up on yet.

@hamishwillee
Copy link
Collaborator Author

hamishwillee commented Nov 21, 2022

@Elchi3 OK, so if the information is provided as intended, then the linked issue is not a bug. I have closed it.

But how do you want to propose following up with making the security section more visible? A discussion thread, so at least it is visible?

Easiest quick fix would be to move this section up to just below the description. The argument for this would be the same as for having secure_context macro in the header.

My instinct is that much of the security stuff is boilerplate, and might be better autogenerated from front matter data. So for example you'd have data (true, false, maybe with a comment) for: transient user activation, secure context, user permission, etc.
From that you might generate a section and boilerplate text, possibly with icons or headers at the top of the page.

PS I'll close this PR once there is a place for discussing the problem. Note, I'd be happy to create this, but I can see you already have some thoughts.

@hamishwillee hamishwillee marked this pull request as draft November 21, 2022 01:36
@Elchi3
Copy link
Member

Elchi3 commented Nov 21, 2022

@Elchi3 OK, so if the information is provided as intended, then the linked issue is not a bug. I have closed it.

But how do you want to propose following up with making the security section more visible? A discussion thread, so at least it is visible?

Yes, I think the front matter ideas from #20435 should be a discussion. I opened one in mdn/mdn-community#288

@hamishwillee
Copy link
Collaborator Author

Cheers. Closing this then.

@Josh-Cena Josh-Cena deleted the hamishwillee-patch-1 branch November 30, 2022 07:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document user activation requirement of the Fullscreen API
2 participants