Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved code on 'a more detailed example' #22497

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Improved code on 'a more detailed example' #22497

merged 2 commits into from
Nov 30, 2022

Conversation

marcusicaro
Copy link
Contributor

Standardize error messages on 'A more detailed example' Javascript code.

Motivation

I felt like standardizing it would give a more professional feel to the example/code.

Additional details

Related issues and pull requests

@marcusicaro
Improved typography on 'a more detailed example'
07b21a2 
On the 'a more detailed example' JS code, the showError() function display messages all but the last one referred 'e-mail' as e-mail. 
To standardize the error messages, I suggest changing the 'else if (email.validity.tooShort)' display error message "email" to 'e-mail'.
Just a small improvement.
@marcusicaro marcusicaro requested a review from a team as a code owner November 23, 2022 12:10
@marcusicaro marcusicaro requested review from hamishwillee and removed request for a team November 23, 2022 12:10
@github-actions github-actions bot added the Content:Learn Learning area docs label Nov 23, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws (3)

URL: /en-US/docs/Learn/Forms/Form_validation
Title: Client-side form validation
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/ValidityState/valueMissing does not exist
    • /en-US/docs/Web/API/ValidityState/customError does not exist
  • broken_links:
    • Link points to the page it's already on

estelle
estelle approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@estelle estelle merged commit 74e7468 into mdn:main Nov 30, 2022
hamishwillee pushed a commit to hamishwillee/content that referenced this pull request Dec 12, 2022
@marcusicaro @hamishwillee
Improved typography on 'a more detailed example' (mdn#22497)
37f54b6 
On the 'a more detailed example' JS code, the showError() function display messages all but the last one referred 'e-mail' as e-mail. 
To standardize the error messages, I suggest changing the 'else if (email.validity.tooShort)' display error message "email" to 'e-mail'.
Just a small improvement.
@marcusicaro marcusicaro changed the title Improved typography on 'a more detailed example' Improved code on 'a more detailed example' Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:Learn Learning area docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcusicaro @estelle