Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates incorrect link text for links to browser_specific_settings #22995

Merged
merged 1 commit into from Dec 16, 2022
Merged

Updates incorrect link text for links to browser_specific_settings #22995

merged 1 commit into from Dec 16, 2022

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Dec 15, 2022

Description

Updates incorrect link text for links to browser_specific_settings

@rebloor rebloor added the Content:WebExt WebExtensions docs label Dec 15, 2022
@rebloor rebloor self-assigned this Dec 15, 2022
@rebloor rebloor requested a review from a team as a code owner December 15, 2022 23:49
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Dec 15, 2022
@github-actions
Copy link
Contributor

Preview URLs (6 pages)

willdurand
willdurand approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@willdurand willdurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks fine, thanks.

Note: applications is still used in Firefox for add-on updates. As long as we replace applications with browser_specific_settings for everything related to a manifest.json file, we should be good, though.

@rebloor
Copy link
Contributor Author

rebloor commented Dec 16, 2022

@willdurand This was the final reference to the applications key name on MDN.

@rebloor rebloor merged commit 27b38cb into mdn:main Dec 16, 2022
@rebloor rebloor deleted the Incorrect-link-text-for-browser_specific_settings branch December 18, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdurand willdurand willdurand approved these changes

Assignees

@rebloor rebloor

Labels
Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rebloor @willdurand