Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CSS): Move out src docs from dl to sub-doc #23375

Merged
merged 12 commits into from
Jan 11, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jan 4, 2023

Opening as draft to get early feedback on the changes.

Changes:
The content of the dl for src under files/en-us/web/css/@font-face/index.md was too extensive and should be moved out into the sub-document for readability.

Alongside this, the src page has some potential improvements to examples and prose.

Fixes #23341

@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/@font-face
Title: @font-face
Flaw count: 1

  • bad_bcd_links:
    • no explanation!
External URLs (2)

URL: /en-US/docs/Web/CSS/@font-face/src
Title: src

(comment last updated: 2023-01-11 13:33:24)

| `woff` | WOFF 1.0 | .woff |
| `woff2` | WOFF 2.0 | .woff2 |

> **Note:** The `opentype` and `truetype` values are equivalent whether the font file uses cubic bezier curves (within CFF/CFF2 table) or quadratic bezier curves (within glyph table).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean? Is there a resource that we can link to explaining this?

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some questions and suggestions. I hope it helps.

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking up this chore! I have just a few quick suggestions for now.

files/en-us/web/css/@font-face/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/src/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/src/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/src/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/src/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/src/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/src/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/src/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/src/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@font-face/src/index.md Outdated Show resolved Hide resolved
@bsmth bsmth marked this pull request as ready for review January 10, 2023 15:47
@bsmth bsmth requested a review from a team as a code owner January 10, 2023 15:47
@bsmth bsmth requested a review from dipikabh January 11, 2023 13:31
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you @bsmth.

@dipikabh dipikabh merged commit 1fd61e8 into mdn:main Jan 11, 2023
@bsmth bsmth deleted the 23341-move-font-face-src branch January 11, 2023 15:58
@bsmth
Copy link
Member Author

bsmth commented Jan 11, 2023

Thanks @dipikabh and @estelle 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move content from the src section in @font-face out to the sub page
4 participants