Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding search.query and search.search disposition #24668

Merged
merged 12 commits into from Mar 3, 2023
Merged

Adding search.query and search.search disposition #24668

merged 12 commits into from Mar 3, 2023

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Feb 21, 2023

Description

Adds documentation for the search.query function and the addition of the disposition property to search.search.

Motivation

Addresses the documentation requirements of Bug 1804357 Implement chrome.search.

Additional details

BCD for this change was previously submitted in #18903

@rebloor rebloor added the Content:WebExt WebExtensions docs label Feb 21, 2023
@rebloor rebloor requested a review from rpl February 21, 2023 01:16
@rebloor rebloor self-assigned this Feb 21, 2023
@rebloor rebloor requested review from a team as code owners February 21, 2023 01:16
@rebloor rebloor requested review from hamishwillee and removed request for a team February 21, 2023 01:16
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label Feb 21, 2023
@rebloor
Copy link
Contributor Author

rebloor commented Feb 21, 2023

FYI @gregorypappas

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2023 •
edited

Preview URLs

External URLs (3)

URL: /en-US/docs/Mozilla/Firefox/Releases/111
Title: Firefox 111 for developers

(comment last updated: 2023-03-03 21:14:16)

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@rebloor rebloor requested review from zombie and removed request for rpl February 26, 2023 21:01
@rebloor
Copy link
Contributor Author

rebloor commented Feb 26, 2023

@zombie would you have a moment to review?

Rob--W
Rob--W requested changes Mar 3, 2023
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search.search and search.query methods are almost identical from the functionality perspective. The main difference is that search.query is cross-browser, and that search.query is Firefox-only and has been around for much longer AND that search.query offers the ability to initiate a search query with a non-default search engine (via the engine) property.

Could you document a comparison between the two to help readers with deciding which method to choose?

@rebloor rebloor requested review from Rob--W and removed request for zombie March 3, 2023 18:09
@rebloor @Rob--W
Incorporate suggested change
b887980 
Co-authored-by: Rob Wu <rob@robwu.nl>
@rebloor rebloor merged commit ad20678 into mdn:main Mar 3, 2023
@rebloor rebloor deleted the search.query-and-search.search-disposition branch March 3, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregorypappas gregorypappas gregorypappas left review comments

@Rob--W Rob--W Rob--W approved these changes

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

Assignees

@rebloor rebloor

Labels
Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rebloor @Rob--W @gregorypappas