Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page orientation 24390 #25176

Merged
merged 32 commits into from Mar 15, 2023
Merged

Page orientation 24390 #25176

merged 32 commits into from Mar 15, 2023

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Mar 8, 2023

Description

Added documentation for the page-orientation descriptor for the @page at-rule

Motivation

Documenting for the Firefox preview release for page-orientation

Additional details

Related issues and pull requests

@dletorey
added the skeleton for page-orientation property
c7883c4
@dletorey
Merge branch 'main' into page-orientation-24390
0185b37
@dletorey
changes before merge
43a9137
@dletorey
Merge branch 'main' into page-orientation-24390
01b2e6a
@dletorey
Merge branch 'main' into page-orientation-24390
ef3a8d5
@dletorey
added syntax & example
c8fafee
@dletorey
Merge branch 'main' into page-orientation-24390
d2e6e15
@dletorey
hidden the code blocks that are not relevant to what's being demonstr…
943fa5c 
…ated
@dletorey
reduced the code blocks for the example and explained what is going on
fcb6644
@dletorey
added the descriptions for the values and added the Formal def
49a4d3e
@dletorey
corrected the text in the example html
23b4592
@dletorey
added note
3ab20a6
@dletorey
Merge branch 'main' into page-orientation-24390
fe0d005
@dletorey
completed the docs for page-orientation for the page at-rule
9a8af58
@dletorey
Merge branch 'main' into page-orientation-24390
8c7b039
@dletorey
Merge branch 'main' into page-orientation-24390
157356b
@dletorey
Merge branch 'main' into page-orientation-24390
fd74b23
@dletorey dletorey requested a review from a team as a code owner March 8, 2023 12:46
@dletorey dletorey requested review from dipikabh and removed request for a team March 8, 2023 12:46
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Mar 8, 2023
@dletorey dletorey mentioned this pull request Mar 8, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023 •
edited

Preview URLs

(comment last updated: 2023-03-15 10:39:00)

@dletorey dletorey mentioned this pull request Mar 8, 2023
Closed
10 tasks
@dipikabh dipikabh self-assigned this Mar 9, 2023
dipikabh
dipikabh requested changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this, @dletorey!

I've added a few comments and suggestions.

files/en-us/web/css/@page/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@page/page-orientation/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@page/page-orientation/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@page/page-orientation/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@page/page-orientation/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@page/page-orientation/index.md Show resolved Hide resolved
files/en-us/web/css/@page/page-orientation/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/@page/page-orientation/index.md

### Result

Click the print button to see the pages rotated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be different example blocks to demo the other orientations Landscape/Left, Landscape/Right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows both orientations, so I don't think so

files/en-us/web/css/@page/page-orientation/index.md Show resolved Hide resolved
files/en-us/web/css/@page/page-orientation/index.md Outdated Show resolved Hide resolved
dletorey and others added 3 commits March 15, 2023 09:53
@dletorey
Merge branch 'main' into page-orientation-24390
1d82403
@dletorey @dipikabh
Update files/en-us/web/css/@page/index.md
38e8d9c 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/@page/page-orientation/index.md
b43f4d1 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
dletorey and others added 11 commits March 15, 2023 10:00
@dletorey @dipikabh
Update files/en-us/web/css/@page/page-orientation/index.md
cc8a8e4 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/@page/page-orientation/index.md
b2d8aa4 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/@page/page-orientation/index.md
97db8f5 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/@page/page-orientation/index.md
9046ea2 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/@page/page-orientation/index.md
0e57f42 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/@page/page-orientation/index.md
e1a0907 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/@page/page-orientation/index.md
98f9185 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/@page/page-orientation/index.md
7549462 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/@page/page-orientation/index.md
3bd8d9b 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey
removed the whitespace in the css as it broke linting rules
77b07fa
@dletorey
added an example of a selector that would be targeted
d3617c0
@dletorey dletorey requested a review from dipikabh March 15, 2023 10:38
dipikabh
dipikabh approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the updates, @dletorey.

@dipikabh dipikabh merged commit 0e015f0 into mdn:main Mar 15, 2023
6 checks passed
@dletorey dletorey deleted the page-orientation-24390 branch March 15, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

Assignees

@dipikabh dipikabh

Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dletorey @dipikabh