Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document ShadowRoot.slotAssignment #25649

Merged
merged 2 commits into from Mar 28, 2023
Merged

Document ShadowRoot.slotAssignment #25649

merged 2 commits into from Mar 28, 2023

Conversation

teoli2003
Copy link
Member

@teoli2003 teoli2003 commented Mar 26, 2023 •
edited

Description

Add documentation for:

  • ShadowRoot.slotAssignement

Motivation

openwebdocs/project#152

Additional details

  • Also updated Element.attachShadow() that sets the value in the first place
  • We should review all examples related to web components, but this is a kind of rabbit hole.

Related issues and pull requests

@teoli2003 teoli2003 requested a review from a team as a code owner March 26, 2023 08:55
@teoli2003 teoli2003 requested review from wbamberg and removed request for a team March 26, 2023 08:55
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 26, 2023
@teoli2003 teoli2003 requested review from Elchi3 and removed request for wbamberg March 26, 2023 08:57
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2023 •
edited

Preview URLs

Flaws (3)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/ShadowRoot
Title: ShadowRoot
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/ShadowRoot/getSelection does not exist
    • /en-US/docs/Web/API/ShadowRoot/elementFromPoint does not exist
    • /en-US/docs/Web/API/ShadowRoot/elementsFromPoint does not exist

(comment last updated: 2023-03-28 10:14:13)

@teoli2003 teoli2003 mentioned this pull request Mar 26, 2023
Merged
@Rumyra Rumyra self-requested a review March 28, 2023 09:56
@teoli2003 @Rumyra
Update files/en-us/web/api/shadowroot/slotassignment/index.md
d7a58bf 
Co-authored-by: Ruth John <Rumyra@users.noreply.github.com>
@teoli2003 teoli2003 requested a review from Rumyra March 28, 2023 10:11
@Rumyra Rumyra merged commit 15f9f28 into mdn:main Mar 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rumyra Rumyra Rumyra approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teoli2003 @Rumyra