Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

25354 of selector #25945

Merged
merged 55 commits into from Apr 27, 2023
Merged

25354 of selector #25945

merged 55 commits into from Apr 27, 2023

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Apr 6, 2023 •
edited

Description

Updated the :nth-child documentation

Motivation

Working on the [CSS] :nth-child(.. of ) enabled on Nightly issue

Additional details

Enable :nth-child(.. of ) on Nightly Bugzilla link

Related issues and pull requests

Browser Compat Data PR
Firefox Release PR

@dletorey dletorey requested a review from a team as a code owner April 6, 2023 09:43
@dletorey dletorey requested review from estelle and removed request for a team April 6, 2023 09:43
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Apr 6, 2023
@dletorey dletorey mentioned this pull request Apr 6, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023 •
edited

Preview URLs

(comment last updated: 2023-04-26 16:25:07)

This was referenced Apr 6, 2023
Closed
Closed
dawei-wang
dawei-wang reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@dawei-wang dawei-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to maintain consistency with a previous heading

files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
estelle
estelle reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great additions. I suggested a few clarifications, hiding some CSS from the examples, increasing the diversity in first names in the examples, and common first names from the countries in the table

files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Show resolved Hide resolved
files/en-us/web/css/_colon_nth-child/index.md Show resolved Hide resolved
dletorey and others added 5 commits April 21, 2023 12:08
@dletorey
Merge branch 'main' into 25354-of-selector
988514b
@dletorey @estelle
Update files/en-us/web/css/_colon_nth-child/index.md
b03495d 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@dletorey @estelle
Update files/en-us/web/css/_colon_nth-child/index.md
9e93ccb 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@dletorey @estelle
Update files/en-us/web/css/_colon_nth-child/index.md
ec0f8f0 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@dletorey @estelle
Update files/en-us/web/css/_colon_nth-child/index.md
0bc35da 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@dletorey dletorey mentioned this pull request Apr 26, 2023
Merged
@dletorey dletorey requested a review from bsmth April 26, 2023 15:01
dletorey and others added 4 commits April 26, 2023 16:41
@dletorey @bsmth
Update files/en-us/web/css/_colon_nth-child/index.md
34a585e 
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@dletorey @bsmth
Update files/en-us/web/css/_colon_nth-child/index.md
f312976 
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@dletorey @bsmth
Update files/en-us/web/css/_colon_nth-child/index.md
4c98cca 
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@dletorey @bsmth
Update files/en-us/web/css/_colon_nth-last-child/index.md
f62c3b8 
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
estelle
estelle approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 09afdce into mdn:main Apr 27, 2023
6 checks passed
@dletorey dletorey deleted the 25354-of-selector branch April 27, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawei-wang dawei-wang dawei-wang left review comments

@bsmth bsmth bsmth left review comments

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dletorey @estelle @dawei-wang @bsmth