Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PWA app icon how-to page #26583

Merged
merged 3 commits into from
May 5, 2023
Merged

Conversation

captainbrosset
Copy link
Contributor

Description

This PR contains a new How-To page on the topic of application icons for PWAs. It goes over aspects such as how to reference icons in the web app manifest, how to design the icon, create the right file sizes and types, and support masks.

Motivation

This is part of a current project to revamp PWA documentation on MDN. See mdn/mdn#280

Additional details

Once this gets merged, a change will also be needed in Yari to add this page to the new PWA sidebar script.

@captainbrosset captainbrosset requested a review from a team as a code owner May 4, 2023 14:12
@captainbrosset captainbrosset requested review from hamishwillee, estelle and wbamberg and removed request for a team May 4, 2023 14:12
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Preview URLs

External URLs (7)

URL: /en-US/docs/Web/Progressive_web_apps/How_to/Define_app_icons
Title: Define your app icons

(comment last updated: 2023-05-05 12:29:47)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent article. A few comments, but they're all minor; suggestions you can take or ignore ;)

@captainbrosset captainbrosset merged commit 051245b into mdn:main May 5, 2023
6 checks passed
@captainbrosset captainbrosset deleted the pwa-icon branch May 5, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants