-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New PWA app icon how-to page #26583
Merged
Merged
New PWA app icon how-to page #26583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainbrosset
requested review from
hamishwillee,
estelle and
wbamberg
and removed request for
a team
May 4, 2023 14:12
github-actions
bot
added
the
Content:Other
Any docs not covered by another "Content:" label
label
May 4, 2023
Preview URLs External URLs (7)URL:
(comment last updated: 2023-05-05 12:29:47) |
estelle
approved these changes
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent article. A few comments, but they're all minor; suggestions you can take or ignore ;)
files/en-us/web/progressive_web_apps/how_to/define_app_icons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/define_app_icons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/define_app_icons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/define_app_icons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/define_app_icons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/define_app_icons/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/how_to/define_app_icons/index.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a new How-To page on the topic of application icons for PWAs. It goes over aspects such as how to reference icons in the web app manifest, how to design the icon, create the right file sizes and types, and support masks.
Motivation
This is part of a current project to revamp PWA documentation on MDN. See mdn/mdn#280
Additional details
Once this gets merged, a change will also be needed in Yari to add this page to the new PWA sidebar script.