-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New PWA best practices guide #26800
New PWA best practices guide #26800
Conversation
Preview URLs External URLs (2)URL:
(comment last updated: 2023-05-22 20:48:46) |
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some feedback....
Main feedback is to indicate that these are PWA requirements not just best practices
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few minor word change suggestions / grammar stuff
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/progressive_web_apps/guides/best_practices/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Thank you @estelle, I committed your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! 🎉
Description
This PR contains a new PWA guide focused on providing high-level best practices for people looking to build the best PWAs possible.
Motivation
We are in the process of re-writing the PWA docs on MDN with @estelle and @wbamberg and have already written a number of guides and how-to tutorials.
We feel like there should also be a Best Practices article in there. That's what this PR does.
Additional details
N/A
Related issues and pull requests
mdn/mdn#280