Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PWA best practices guide #26800

Merged
merged 6 commits into from
May 22, 2023
Merged

Conversation

captainbrosset
Copy link
Contributor

Description

This PR contains a new PWA guide focused on providing high-level best practices for people looking to build the best PWAs possible.

Motivation

We are in the process of re-writing the PWA docs on MDN with @estelle and @wbamberg and have already written a number of guides and how-to tutorials.

We feel like there should also be a Best Practices article in there. That's what this PR does.

Additional details

N/A

Related issues and pull requests

mdn/mdn#280

@captainbrosset captainbrosset requested a review from a team as a code owner May 16, 2023 14:09
@captainbrosset captainbrosset requested review from Elchi3 and removed request for a team May 16, 2023 14:09
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label May 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

Preview URLs

External URLs (2)

URL: /en-US/docs/Web/Progressive_web_apps/Guides/Best_practices
Title: Best practices for PWAs

(comment last updated: 2023-05-22 20:48:46)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some feedback....

Main feedback is to indicate that these are PWA requirements not just best practices

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great.

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few minor word change suggestions / grammar stuff

Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@captainbrosset
Copy link
Contributor Author

Thank you @estelle, I committed your suggestions.

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🎉

@estelle estelle merged commit c27f8c4 into mdn:main May 22, 2023
6 checks passed
@captainbrosset captainbrosset deleted the pwa-best-practices branch May 23, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants