Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently link DNR examples #26802

Merged
merged 1 commit into from
May 16, 2023
Merged

Consistently link DNR examples #26802

merged 1 commit into from
May 16, 2023

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented May 16, 2023

Description

Consistently link DNR examples (even if there are not any). Some DNR examples are added in mdn/webextensions-examples#526

Note: the declarative_net_request manually links the test cases since the WebExtExamples template doesn't support auto-generation yet (mdn/webextensions-examples#524).

Motivation

Additional details

Related issues and pull requests

@Rob--W
Consistently link DNR examples
969860f 
- Use h2 when there is no "Examples" header.
- Link WebExtExamples when they were not linked yet.
- Manually link examples from declarative_net_request since the
  WebExtExamples template doesn't support auto-generation yet.
@Rob--W Rob--W added the Content:WebExt WebExtensions docs label May 16, 2023
@Rob--W Rob--W requested a review from a team as a code owner May 16, 2023 15:57
@Rob--W Rob--W requested review from rebloor and removed request for a team May 16, 2023 15:57
@github-actions github-actions bot added the Content:Other Any docs not covered by another "Content:" label label May 16, 2023
@github-actions
Copy link
Contributor

Preview URLs (18 pages)
Flaws (11)

Note! 11 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/onRuleMatchedDebug
Title: declarativeNetRequest.onRuleMatchedDebug
Flaw count: 1

  • broken_links:
    • Can't resolve /docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest#testing

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/RuleAction
Title: declarativeNetRequest.RuleAction
Flaw count: 3

  • broken_links:
    • Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions#host_permissions
    • Can't resolve /docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest#permissions
    • Can't resolve /docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest#matching_precedents

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/RuleCondition
Title: declarativeNetRequest.RuleCondition
Flaw count: 1

  • broken_links:
    • Can't resolve /docs/Web/API/URL

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/MAX_NUMBER_OF_ENABLED_STATIC_RULESETS
Title: declarativeNetRequest.MAX_NUMBER_OF_ENABLED_STATIC_RULESETS
Flaw count: 1

  • broken_links:
    • Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/Rule
Title: declarativeNetRequest.Rule
Flaw count: 2

  • broken_links:
    • Can't resolve /docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest#rules
    • Can't resolve /docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest#matching_precedents

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/MatchedRule
Title: declarativeNetRequest.MatchedRule
Flaw count: 2

  • broken_links:
    • Can't resolve /docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest#rulesets
    • Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/declarativeNetRequest/MAX_NUMBER_OF_STATIC_RULESETS
Title: declarativeNetRequest.MAX_NUMBER_OF_STATIC_RULESETS
Flaw count: 1

  • broken_links:
    • Can't resolve /docs/Mozilla/Add-ons/WebExtensions/manifest.json/declarative_net_request

@rebloor rebloor merged commit 12d23fc into mdn:main May 16, 2023
@Rob--W Rob--W mentioned this pull request Aug 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebloor rebloor rebloor approved these changes

Assignees
No one assigned
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rob--W @rebloor