Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.md #27043

Merged
merged 1 commit into from May 30, 2023
Merged

Update index.md #27043

merged 1 commit into from May 30, 2023

Conversation

luyang1026
Copy link
Contributor

Description

there is a bug: this.result is undefined because arrow function is used so I changed this to declared variable 'reader'

Motivation

bug fix

Additional details

Related issues and pull requests

@luyang1026 luyang1026 requested a review from a team as a code owner May 30, 2023 09:39
@luyang1026 luyang1026 requested review from sideshowbarker and removed request for a team May 30, 2023 09:39
@github-actions github-actions bot added the Content:WebAPI Web API docs label May 30, 2023
@github-actions
Copy link
Contributor

Preview URLs

Flaws (3)

URL: /en-US/docs/Web/API/FileReader/readAsDataURL
Title: FileReader: readAsDataURL() method
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • /en-US/docs/Web/API/URL/createObjectURL redirects to /en-US/docs/Web/API/URL/createObjectURL_static

wbamberg
wbamberg approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you @luyang1026 !

@wbamberg wbamberg merged commit 065395a into mdn:main May 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luyang1026 @wbamberg