Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CSS): Rename '@media/update-frequency' to '@media/update' #27501

Merged
merged 2 commits into from Jun 23, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jun 23, 2023

It looks like we should follow this convention for naming although frequency adds some hints on the behavior, the suggested changes are more uniform given the syntax:

@media (update: <value>) {
...

Renaming this page along with updating references to the old slug / name.

@bsmth bsmth requested a review from dipikabh June 23, 2023 09:08
@bsmth bsmth requested review from a team as code owners June 23, 2023 09:08
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Other Any docs not covered by another "Content:" label labels Jun 23, 2023
@github-actions
Copy link
Contributor

Preview URLs

Flaws (2)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/@media/update
Title: update
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_Animations
    • Can't resolve /en-US/docs/Web/CSS/Media_Queries/Using_media_queries
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/102
Title: Firefox 102 for developers

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates!

@dipikabh dipikabh merged commit 225de7f into mdn:main Jun 23, 2023
6 checks passed
@bsmth bsmth deleted the media-scan branch June 23, 2023 13:25
@bsmth
Copy link
Member Author

bsmth commented Jun 23, 2023

Thank you!

behnammodi pushed a commit to behnammodi/content that referenced this pull request Jun 26, 2023
…7501)

* docs(CSS): Change media update-frequency to update

* docs(CSS): Change media update-frequency to update
@bsmth bsmth mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Other Any docs not covered by another "Content:" label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants