-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promise support in Chrome clarification #28643
promise support in Chrome clarification #28643
Conversation
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edge does not need to be mentioned separately; it's basically a Chrome clone.
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/differences_between_api_implementations/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Rob Wu <rob@robwu.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for merging, provided that all suggested changes are included. Feel free to copy-edit, but please request another review if the content is changed in substantial ways.
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
|
||
To work cross-browser, you can specify the path as an absolute URL, starting at the extension's root, like this: | ||
|
||
```plain | ||
/path/to/script.js | ||
``` | ||
|
||
When querying tabs by URL `tabs.query()`: | ||
When querying tabs by URL, with `tabs.query()`: | ||
|
||
- **In Firefox**: Extensions must have the `"tabs"` permission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firefox and Chrome's behavior is the same here. Remove this whole section on tabs.query
.
This was implemented by Firefox in https://bugzilla.mozilla.org/show_bug.cgi?id=1679688.
files/en-us/mozilla/add-ons/webextensions/chrome_incompatibilities/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Rob Wu <rob@robwu.nl>
@@ -73,21 +73,22 @@ The rest of this page summarizes these and other incompatibilities. | |||
chrome.cookies.set({ url: "https://developer.mozilla.org/" }, logCookie); | |||
``` | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[mdn-linter] reported by reviewdog 🐶
Description
Addresses the dev-doc-needed for Bug 1711570 support promises on chrome namespace. Also includes miscellaneous edits.