Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promise support in Chrome clarification #28643

Merged
merged 6 commits into from
Oct 2, 2023

Conversation

rebloor
Copy link
Contributor

@rebloor rebloor commented Aug 18, 2023

Description

Addresses the dev-doc-needed for Bug 1711570 support promises on chrome namespace. Also includes miscellaneous edits.

@rebloor rebloor added the Content:WebExt WebExtensions docs label Aug 18, 2023
@rebloor rebloor requested review from rpl and Rob--W August 18, 2023 03:57
@rebloor rebloor requested a review from a team as a code owner August 18, 2023 03:57
@rebloor rebloor self-assigned this Aug 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

Preview URLs

External URLs (14)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Chrome_incompatibilities
Title: Chrome incompatibilities


URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Differences_between_API_implementations
Title: Differences between API implementations

(comment last updated: 2023-10-02 00:46:21)

Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edge does not need to be mentioned separately; it's basically a Chrome clone.

@rebloor rebloor requested a review from Rob--W September 1, 2023 16:24
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merging, provided that all suggested changes are included. Feel free to copy-edit, but please request another review if the content is changed in substantial ways.


To work cross-browser, you can specify the path as an absolute URL, starting at the extension's root, like this:

```plain
/path/to/script.js
```

When querying tabs by URL `tabs.query()`:
When querying tabs by URL, with `tabs.query()`:

- **In Firefox**: Extensions must have the `"tabs"` permission.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefox and Chrome's behavior is the same here. Remove this whole section on tabs.query.

This was implemented by Firefox in https://bugzilla.mozilla.org/show_bug.cgi?id=1679688.

Co-authored-by: Rob Wu <rob@robwu.nl>
@@ -73,21 +73,22 @@ The rest of this page summarizes these and other incompatibilities.
chrome.cookies.set({ url: "https://developer.mozilla.org/" }, logCookie);
```


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[mdn-linter] reported by reviewdog 🐶

Suggested change

@rebloor rebloor merged commit 311a791 into mdn:main Oct 2, 2023
6 checks passed
@rebloor rebloor deleted the promise-support-in-chrome-clarification branch October 2, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebExt WebExtensions docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants