-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WASM memory.copy and memory.fill docs #29077
Conversation
Preview URLs
(comment last updated: 2024-02-06 16:13:53) |
Thanks for the additions. Tagging @pepelsbey here who may be interested in these changes. |
We might want to ask @eqrion for a review. As for the docs, what is the browser support for these? We don’t usually document proposals or even spec additions before they ship into browsers. |
bulk-memory-ops has had good browser support for many years now: https://webassembly.org/roadmap/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long-overdue approval. It should be good to go!
Thank you! |
Description
Add documentation for the
memory.copy
andmemory.fill
instructions to the WASM referenceMotivation
These were added by the bulk memory operations proposal. They are already in the spec:
Additional details
There was also a
memory.fill
instruction added, but I don't understand it well enough to document.Related issues and pull requests
I didn't find anything related