Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WASM memory.copy and memory.fill docs #29077

Merged
merged 12 commits into from
Feb 6, 2024
Merged

Conversation

felipeochoa
Copy link
Contributor

@felipeochoa felipeochoa commented Sep 12, 2023

Description

Add documentation for the memory.copy and memory.fill instructions to the WASM reference

Motivation

These were added by the bulk memory operations proposal. They are already in the spec:

The memory.fill instruction sets all values in a region to a given byte. The memory.copy instruction copies data from a source memory region to a possibly overlapping destination region.

Additional details

There was also a memory.fill instruction added, but I don't understand it well enough to document.

Related issues and pull requests

I didn't find anything related

@felipeochoa felipeochoa requested a review from a team as a code owner September 12, 2023 17:09
@felipeochoa felipeochoa requested review from Elchi3 and removed request for a team September 12, 2023 17:09
@github-actions github-actions bot added the Content:wasm WebAssembly docs label Sep 12, 2023
felipeochoa and others added 5 commits September 12, 2023 12:10
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

@bsmth
Copy link
Member

bsmth commented Dec 18, 2023

Thanks for the additions. Tagging @pepelsbey here who may be interested in these changes.

@pepelsbey
Copy link
Member

pepelsbey commented Dec 18, 2023

We might want to ask @eqrion for a review.

As for the docs, what is the browser support for these? We don’t usually document proposals or even spec additions before they ship into browsers.

@eqrion
Copy link

eqrion commented Dec 19, 2023

We might want to ask @eqrion for a review.

As for the docs, what is the browser support for these? We don’t usually document proposals or even spec additions before they ship into browsers.

bulk-memory-ops has had good browser support for many years now: https://webassembly.org/roadmap/

Copy link

@eqrion eqrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

files/en-us/webassembly/reference/memory/copy/index.md Outdated Show resolved Hide resolved
@bsmth bsmth requested a review from pepelsbey December 20, 2023 11:02
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Feb 6, 2024
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long-overdue approval. It should be good to go!

@pepelsbey pepelsbey merged commit f39703b into mdn:main Feb 6, 2024
8 checks passed
@pepelsbey
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:wasm WebAssembly docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants