Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relnote(121): Date.parse fixes and additions #30234

Merged
merged 2 commits into from Nov 20, 2023

Conversation

vinnydiehl
Copy link
Contributor

Entry

  • Date.parse() now accepts several additional date formats:

    • Year > 9999 for YYYY-MMM-DD format (e.g. 19999-Jan-01)

    • MMM-DD-YYYY (e.g. Jan-01-1970)

    • Milliseconds for non-ISO date formats (e.g. Jan 1 1970 10:00:00.050)

    • Day of week at the beginning of formats which were being rejected, such as:

      • Wed, 1970-01-01
      • Wed, 1970-Jan-01

      The day of week does not need to be correct, or a day of week at all; for example, foo 1970-01-01 works.

  • Other Date.parse() fixes:

    • YYYY-M-DD and YYYY-MM-D are no longer assumed GMT as an ISO date YYYY-MM-DD would be
    • Milliseconds for all formats are truncated after 3 digits, rather than being rounded

Bugzilla

In the order of the entries:

@vinnydiehl vinnydiehl requested a review from a team as a code owner November 13, 2023 10:29
@vinnydiehl vinnydiehl requested review from zfox23 and removed request for a team November 13, 2023 10:29
@github-actions github-actions bot added the Content:Firefox Content in the Mozilla/Firefox subtree label Nov 13, 2023
Copy link
Contributor

github-actions bot commented Nov 13, 2023

Preview URLs

External URLs (6)

URL: /en-US/docs/Mozilla/Firefox/Releases/121
Title: Firefox 121 for developers

(comment last updated: 2023-11-18 08:44:29)

@hamishwillee
Copy link
Collaborator

Does this also have corresponding docs updates required? See #30235 (comment)

@zfox23
Copy link
Contributor

zfox23 commented Nov 15, 2023

Even though there are quite a few associated bugs, I think it'd be helpful to link each element in your list to the relevant Bugzilla ticket. WDYT about adding that context to your list?

Copy link
Contributor

@zfox23 zfox23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added relevant Bugzilla links - thanks!

files/en-us/mozilla/firefox/releases/121/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/121/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/121/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/121/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/121/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/121/index.md Outdated Show resolved Hide resolved
Co-authored-by: Zach Fox <3409031+zfox23@users.noreply.github.com>
@zfox23 zfox23 merged commit a19d749 into mdn:main Nov 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants