Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Drag operations article of uninitialized property description #30265

Merged
merged 9 commits into from Mar 28, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 14, 2023

Description

the uninitialized is a valid value for DataTransfer.effectAllowed and is the initial value if it is not set yet, the documentation there behave like if the uninitialized is not a valid value and is simply a state that represent as all value

also fix some spell and make some style update

Motivation

Additional details

Working on https://developer.mozilla.org/en-US/docs/Web/API/HTML_Drag_and_Drop_API/Drag_operations

reference to https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-effectallowed and https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/effectAllowed

Related issues and pull requests

@github-actions github-actions bot added the Content:WebAPI Web API docs label Nov 14, 2023
@skyclouds2001 skyclouds2001 changed the title fix fix Drag operations article Nov 14, 2023
Copy link
Contributor

github-actions bot commented Nov 14, 2023

Preview URLs

(comment last updated: 2024-03-28 16:04:51)

@skyclouds2001 skyclouds2001 changed the title fix Drag operations article fix Drag operations article of uninitialized property description Nov 14, 2023
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 14, 2023 12:58
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner November 14, 2023 12:58
@skyclouds2001 skyclouds2001 requested review from Elchi3 and removed request for a team November 14, 2023 12:58
@skyclouds2001
Copy link
Contributor Author

skyclouds2001 commented Nov 15, 2023

also, I noticed #8404, and the issue seems to be fixed yet, as I didn't find any reference about these two proerties yet when searching in this repository, expect for the firefox release note

@github-actions github-actions bot added the size/s 6-50 LoC changed label Mar 13, 2024
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bsmth bsmth merged commit 1a020e7 into mdn:main Mar 28, 2024
9 checks passed
@skyclouds2001 skyclouds2001 deleted the drag-drop branch March 28, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants