-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CustomStateSet plus using custom elements #30566
Conversation
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
7ea2221
to
8a4b6dd
Compare
Thanks for the review @bsmth - very helpful. I've merged the changes with very minor modifications. Yes, this example doesn't work properly on FF. I'm OK with that while it is behind a preference. It matches the spec, and works on chrome. |
Super, thanks!
Agreed, looking good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hamish, merging shortly 🚢
* CustomStateSet plus using custom elements * ElementInternals is WebComponent specialization of DOM * CustomStateSet is WebComponent specialization of DOM * Add ElementInternals and CustomStateSet to the WebComponents API * CustomStateSet - correct and uses the checkbox * Cross link to Using custom elements * Make my custom element a block element * Fix up to use annoying heading separaters meh * Apply suggestions from code review Co-authored-by: Brian Thomas Smith <brian@smith.berlin> * Apply suggestions from code review --------- Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
This updates CustomStateSet and Using custom components to reflect the addition of support for exposing states from a custom web component so that they can be used as a selector for CSS.
Note, it also moves CustomStateSet and ElementInternals into the Web Components sidebar rather than DOM sidebar - of course all of these are also DOM, but they can only be used in custom components.
Things to do.
CustomStateSet
CustomStateList
Related docs work in #30339