Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF122 ExprFeatre: Element.checkVisibility() supports options.contentVisibilityAuto #31215

Merged

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Dec 22, 2023

FF122 adds support to get whether an element's rendering is been skipped due to content-visibility:auto being set. The support is a new property of the Element.checkVisibility() options parameter object named contentVisibilityAuto. There are also two other options opacityProperty and visibilityProperty created as aliases of other existing options in the same bugzilla https://bugzilla.mozilla.org/show_bug.cgi?id=1859852

There are two complications:

  • The CSS that allows content to be skipped is in preview. That means that checkVisibility() will always return the correct value even now (because it will be false if not in preview).
  • The other two properties are not related to the content-visibility features.

So I think these new options are effectively released, but I'm not sure, and I'm in discussion with BCD/engineering.

For now I have put all these options in experimental features associated with the content-visibility:auto information. I would have some of this information here in any case. But I may need to move some of it to release notes depending on how the discussion falls out with BCD team.

Other docs work for this can be tracked in #31107

@hamishwillee hamishwillee requested a review from a team as a code owner December 22, 2023 04:48
@hamishwillee hamishwillee requested review from pepelsbey and removed request for a team December 22, 2023 04:48
@github-actions github-actions bot added the Content:Firefox Content in the Mozilla/Firefox subtree label Dec 22, 2023
Copy link
Contributor

github-actions bot commented Dec 22, 2023

Preview URLs

Flaws (1)

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Element/checkVisibility does not exist
External URLs (2)

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2024-01-08 00:01:42)

@hamishwillee hamishwillee force-pushed the ff122_nightly_checkvisility_options branch from b93a74c to be52f66 Compare January 2, 2024 03:18
@hamishwillee
Copy link
Collaborator Author

@pepelsbey I'm away for a couple of weeks from tomorrow so if you can't look at this today I won't be here to respond to any review comments. If the comments are just editorial, please integrate and self-merge. I will also try find someone else to look at this today in case you are away still.

Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 9bc39b0 into mdn:main Jan 8, 2024
7 checks passed
@hamishwillee hamishwillee deleted the ff122_nightly_checkvisility_options branch January 8, 2024 05:35
estelle pushed a commit to estelle/content that referenced this pull request Jan 9, 2024
…isibilityAuto (mdn#31215)

* FF122 ExprFeatre: Element.checkVisibility() supports options.contentVisibilityAuto property

* Update files/en-us/mozilla/firefox/experimental_features/index.md
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
…isibilityAuto (mdn#31215)

* FF122 ExprFeatre: Element.checkVisibility() supports options.contentVisibilityAuto property

* Update files/en-us/mozilla/firefox/experimental_features/index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants