Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autocomplete attribute of <button> element #31605

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Jan 9, 2024

Description

see detail at BCD update mdn/browser-compat-data#21876

Motivation

Additional details

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 9, 2024 08:47
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner January 9, 2024 08:47
@skyclouds2001 skyclouds2001 requested review from dipikabh and removed request for a team January 9, 2024 08:47
@dipikabh dipikabh self-assigned this Jan 9, 2024
@dipikabh
Copy link
Contributor

dipikabh commented Jan 9, 2024

@skyclouds2001, the removal of autocomplete attribute for the <button> element seems correct (checked in Firefox 121). We also don't have a mention of <button> on the autocomplete attribute page. You've spotted correctly in the BCD PR that the links to the Firefox bug and Stackoverflow are not referring to the autocomplete attribute on the <button> element. Let's wait for the BCD PR to go through and then I can merge this one.

@Elchi3
Copy link
Member

Elchi3 commented Jan 22, 2024

I merged the BCD PR.

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @skyclouds2001

@dipikabh dipikabh merged commit b05dec8 into mdn:main Jan 23, 2024
7 checks passed
@skyclouds2001 skyclouds2001 deleted the html-button-autocomplete branch January 23, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants