Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCDataChannelStats - add docs #32498

Merged
merged 4 commits into from
Jun 9, 2024
Merged

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Mar 1, 2024

This adds docs for RTCDataChannelStats, a "codec statistics" object/dictionary you can get by iterating a RTCStatsReport.

It is not very exciting. Largely following the same patterns as the other docs.

This is part of the ongoing work to finished RTC stats, which was started in #27028

@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Mar 1, 2024
Comment on lines +32 to +33
- {{domxref("RTCDataChannelStats.state", "state")}}
- : The {{domxref("RTCDataChannel.readyState", "readyState")}} of the associated `RTCDataChannel`.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI This is marked as required in the IDL, as are the common properties below. The rest are not, and are therefore optional. I've marked those as optional inline here for the other ones, but how should I mark up the detailed property docs as there is no "Optional header" macro?

The whole thing is a bit odd because this isn't like a dictionary passed as an argument - the required is more an instruction to the browser vendor that they are expected to provide the information rather than to users.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how should I mark up the detailed property docs as there is no "Optional header" macro?

I would just leave this. As you say it is a weird case.

@hamishwillee hamishwillee marked this pull request as ready for review March 4, 2024 03:27
@hamishwillee hamishwillee requested review from a team as code owners March 4, 2024 03:27
@hamishwillee hamishwillee requested review from sideshowbarker, pepelsbey and wbamberg and removed request for a team March 4, 2024 03:27
@sideshowbarker sideshowbarker removed their request for review March 4, 2024 04:14
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Mar 14, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Mar 14, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added merge conflicts 🚧 [PR only] and removed merge conflicts 🚧 [PR only] labels Mar 22, 2024
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of super-nits, so approving but not merging.

Co-authored-by: wbamberg <will@bootbonnet.ca>
@Josh-Cena Josh-Cena merged commit 7e6058c into mdn:main Jun 9, 2024
9 checks passed
@hamishwillee
Copy link
Collaborator Author

Thanks very much for merging (and also for reviewing). I thought there would be more to it than this so had been waiting to find a spare few hours.

@hamishwillee hamishwillee deleted the RTCDataChannelStats branch June 9, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants