-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api): Make macros with line breaks span a single line only, 4 of 4 #32584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsmth
requested review from
wbamberg and
teoli2003
and removed request for
a team
March 6, 2024 13:12
github-actions
bot
added
Content:WebAPI
Web API docs
Content:JS
JavaScript docs
Content:HTTP
HTTP docs
labels
Mar 6, 2024
4 tasks
This was referenced Mar 6, 2024
files/en-us/web/api/webgl2renderingcontext/vertexattribdivisor/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/webglrenderingcontext/enablevertexattribarray/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/webglrenderingcontext/vertexattrib/index.md
Outdated
Show resolved
Hide resolved
hamishwillee
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one thanks.
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Content:HTTP
HTTP docs
Content:JS
JavaScript docs
Content:WebAPI
Web API docs
macros
Work relating to macro refactoring or removal
size/m
51-500 LoC changed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes macros that span multiple lines span a single lines only.
Motivation
Removing poor authoring patterns, helping to make the documentation more ergonomic and readable for authors and easier to maintain in future when we want to remove or update these macros.
Related issues and pull requests