Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): Make macros with line breaks span a single line only, 4 of 4 #32584

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Mar 6, 2024

Description

This PR makes macros that span multiple lines span a single lines only.

Motivation

Removing poor authoring patterns, helping to make the documentation more ergonomic and readable for authors and easier to maintain in future when we want to remove or update these macros.

Related issues and pull requests

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Preview URLs (56 pages)
Flaws (1)

Note! 55 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/XRReferenceSpace/getOffsetReferenceSpace
Title: XRReferenceSpace: getOffsetReferenceSpace() method
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Element/oncontextmenu does not exist

(comment last updated: 2024-03-11 23:57:31)

@bsmth bsmth added the macros Work relating to macro refactoring or removal label Mar 6, 2024
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one thanks.

@hamishwillee hamishwillee merged commit 8a9085b into mdn:main Mar 11, 2024
9 checks passed
@bsmth bsmth deleted the macro-cleanup-vol-4 branch March 12, 2024 08:35
@bsmth
Copy link
Member Author

bsmth commented Mar 12, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs Content:JS JavaScript docs Content:WebAPI Web API docs macros Work relating to macro refactoring or removal size/m 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants