Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aria-label): Improve page for clarity #32688
fix(aria-label): Improve page for clarity #32688
Changes from 3 commits
4636eaa
7e8502c
b11985f
bf2e103
66d7c8a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the plural made it sound like an element can have more than one accessible name. It is correct to use "names", but "name" is also ok, and less likely to create confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you estelle. i was feeling very iffy about these updates - so i'm glad you share my concern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably the right fix here would be to also make "content" singular:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would remove the example of figure > figcaption. since (though this is taking a while to get full implementation) figcaption will not provide a name to figure in the future. this was generally considered too noisy and redundant, especially since figcaptions can contain structured content which would not have their semantics communicated in the flattened text string that becomes the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, both!
Fixing the last sentence as:
@scottaohara thanks for the insights into the future direction of figure > figcaption regarding accessible name. I've removed their mention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't entirely true. it's not just interactive elements that aria-label or aria-labelledby can be used with. I realize this wasn't a change made in this PR, but since this PR is open, this information should be corrected. There are various non-interactive elemetns which can benefit from having an aria-label/labelledby name, if one can't use the native features to provide one (e.g., tables, fieldsets)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scottaohara I'm glad you mentioned this because I started looking at this page precisely because of this issue raised here: The documentation for aria-label mentions that this is for interactive elements only, but this doesn't seem right #31739
There are two instances on the page that mention that
aria-label
should be used for interactive elements only.hidden
):definition
was missing.