Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify glossary entry #32829

Merged
merged 2 commits into from Mar 28, 2024
Merged

Clarify glossary entry #32829

merged 2 commits into from Mar 28, 2024

Conversation

dawei-wang
Copy link
Contributor

Remove mention of object.create as a copying technique per #32815 (comment)

Fix #32815

Description

Motivation

Additional details

Related issues and pull requests

Remove mention of object.create as a copying technique per mdn#32815 (comment)
Fix mdn#32815
@dawei-wang dawei-wang requested a review from a team as a code owner March 25, 2024 23:23
@dawei-wang dawei-wang requested review from chrisdavidmills and removed request for a team March 25, 2024 23:23
@github-actions github-actions bot added Content:Glossary Glossary entries size/xs 0-5 LoC changed labels Mar 25, 2024
Copy link
Contributor

github-actions bot commented Mar 25, 2024

Preview URLs

(comment last updated: 2024-03-27 23:18:17)

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change deep copy too?

Remove object.create from deep_copy
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Josh-Cena Josh-Cena merged commit 3114504 into mdn:main Mar 28, 2024
9 checks passed
@dawei-wang dawei-wang deleted the patch-2 branch March 28, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries size/xs 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object.create don't do shallow copies... Does?
2 participants