Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oklch): prevent hue from changing when exemplifying chroma change #32867

Merged
merged 2 commits into from Mar 27, 2024

Conversation

vhoyer
Copy link
Contributor

@vhoyer vhoyer commented Mar 27, 2024

Description

the commit msg says it all

Motivation

I think that was an oversight, the old color is more pleasant, but it doesn't let readers grasp what the chroma does to the color, as it seems it's the objective of that section

Additional details

Related issues and pull requests

@vhoyer vhoyer requested a review from a team as a code owner March 27, 2024 19:02
@vhoyer vhoyer requested review from estelle and removed request for a team March 27, 2024 19:02
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs 0-5 LoC changed labels Mar 27, 2024
Copy link
Contributor

github-actions bot commented Mar 27, 2024

Preview URLs

(comment last updated: 2024-03-27 21:48:05)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Also, congratulations on your first merged MDN content PR. Welcome to he team!

files/en-us/web/css/color_value/oklch/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/color_value/oklch/index.md Outdated Show resolved Hide resolved
@estelle estelle merged commit 1081182 into mdn:main Mar 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/xs 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants