update learn background and borders #33143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add features supported since this was written a LONG time ago.
github-actions
bot
added
Content:Learn:CSS
|
Preview URLs External URLs (1)URL:
(comment last updated: 2024-04-18 16:39:11) |
chrisdavidmills
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Looking good, nice work @estelle! Just a couple of small bits for you to consider, so approving.
| @@ -81,6 +81,8 @@ The {{cssxref("background-repeat")}} property is used to control the tiling beha | |||
| - `repeat-x` — repeat horizontally. | |||
| - `repeat-y` — repeat vertically. | |||
| - `repeat` — the default; repeat in both directions. | |||
| - `space` — repeat as many times as possible, adding space between the images if there is extra space. | |||
There was a problem hiding this comment.
Suggested change
| - `space` — repeat as many times as possible, adding space between the images if there is extra space. | |
| - `space` — repeat as many times as possible, adding space between the images if there is extra space to fill. |
| @@ -81,6 +81,8 @@ The {{cssxref("background-repeat")}} property is used to control the tiling beha | |||
| - `repeat-x` — repeat horizontally. | |||
| - `repeat-y` — repeat vertically. | |||
| - `repeat` — the default; repeat in both directions. | |||
| - `space` — repeat as many times as possible, adding space between the images if there is extra space. | |||
| - `round` — similar to `space`, but stretches the image to fill any extra space | |||
There was a problem hiding this comment.
Suggested change
| - `round` — similar to `space`, but stretches the image to fill any extra space | |
| - `round` — similar to `space`, but stretches the images to fill any extra space. |
| @@ -163,7 +165,7 @@ Finally, you can also use a 4-value syntax in order to indicate a distance from | |||
|
|
|||
| A gradient — when used for a background — acts just like an image and is also set by using the {{cssxref("background-image")}} property. | |||
|
|
|||
| You can read more about the different types of gradients and things you can do with them on the MDN page for the [`<gradient>`](/en-US/docs/Web/CSS/gradient) data type. A fun way to play with gradients is to use one of the many CSS Gradient Generators available on the web, such as [this one](https://cssgradient.io/). You can create a gradient then copy and paste out the source code that generates it. | |||
| You can read more about the six different types of gradients and things you can do with them on the MDN page for the [`<gradient>`](/en-US/docs/Web/CSS/gradient) data type. A fun way to play with gradients is to use one of the many CSS Gradient Generators available on the web, such as [CSSGradient.io](https://cssgradient.io/). You can create a gradient then copy and paste out the source code that generates it. | |||
There was a problem hiding this comment.
Add "six" here doesn't seem necessary — just makes it less future proof?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add features supported since this was written a LONG time ago.
link more stuff to internal resources