Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix globals, part 2: isSecureContext #33224

Merged
merged 1 commit into from Apr 25, 2024
Merged

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Apr 23, 2024

@github-actions github-actions bot added Content:WebAPI Web API docs Content:Security Security docs Content:Firefox Content in the Mozilla/Firefox subtree size/m 51-500 LoC changed labels Apr 23, 2024
Copy link
Contributor

Preview URLs (7 pages)
Flaws (3)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/49
Title: Firefox 49 for developers
Flaw count: 3

  • macros:
    • /en-US/docs/Web/CSS/align does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Performance_Timeline
    • Can't resolve /en-US/docs/Mozilla/Projects/Necko/Proxy_Auto-Configuration_(PAC)_file
External URLs (2)

URL: /en-US/docs/Mozilla/Firefox/Releases/52
Title: Firefox 52 for developers


URL: /en-US/docs/Mozilla/Firefox/Releases/49
Title: Firefox 49 for developers

@skyclouds2001 skyclouds2001 marked this pull request as ready for review April 23, 2024 09:21
@skyclouds2001 skyclouds2001 requested review from a team as code owners April 23, 2024 09:21
@skyclouds2001 skyclouds2001 requested review from sideshowbarker and removed request for a team April 23, 2024 09:21
@sideshowbarker sideshowbarker removed their request for review April 23, 2024 12:20
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great, thank you @skyclouds2001 !

@wbamberg wbamberg merged commit 964e225 into mdn:main Apr 25, 2024
8 checks passed
yin1999 added a commit to mdn/translated-content that referenced this pull request Apr 26, 2024
yin1999 added a commit to mdn/translated-content that referenced this pull request Apr 26, 2024
@skyclouds2001 skyclouds2001 deleted the isSecureContext branch April 26, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:Security Security docs Content:WebAPI Web API docs size/m 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants