Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix globals, part 7: caches #33359

Merged
merged 9 commits into from
May 18, 2024
Merged

Fix globals, part 7: caches #33359

merged 9 commits into from
May 18, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented May 1, 2024 •
edited

part of the #33019
/cc @wbamberg

@github-actions github-actions bot added Content:WebAPI Web API docs Content:Firefox Content in the Mozilla/Firefox subtree Content:PWA Progressive Web Apps content size/m 51-500 LoC changed labels May 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024 •
edited

Preview URLs (21 pages)

(comment last updated: 2024-05-18 15:19:18)

@skyclouds2001 skyclouds2001 marked this pull request as ready for review May 1, 2024 20:18
@skyclouds2001 skyclouds2001 requested review from a team as code owners May 1, 2024 20:18
@skyclouds2001 skyclouds2001 requested review from wbamberg and pepelsbey and removed request for a team May 1, 2024 20:18
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@skyclouds2001 skyclouds2001 changed the title Fix globals, part 7: caches Fix globals, part 7: caches May 14, 2024
skyclouds2001
skyclouds2001 commented May 16, 2024
View reviewed changes
files/en-us/mozilla/firefox/releases/103/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/cachestorage/delete/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/cachestorage/has/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/cachestorage/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/cachestorage/keys/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/cachestorage/match/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/cachestorage/open/index.md Outdated Show resolved Hide resolved
files/en-us/web/progressive_web_apps/tutorials/cycletracker/service_workers/index.md Outdated Show resolved Hide resolved
wbamberg
wbamberg requested changes May 17, 2024
View reviewed changes
files/en-us/web/api/window/caches/index.md Show resolved Hide resolved
files/en-us/web/api/cachestorage/delete/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/cachestorage/has/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/cachestorage/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/cachestorage/keys/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/cachestorage/match/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/cachestorage/open/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/window/caches/index.md Outdated Show resolved Hide resolved
files/en-us/web/progressive_web_apps/tutorials/cycletracker/service_workers/index.md Outdated Show resolved Hide resolved
files/en-us/web/progressive_web_apps/tutorials/cycletracker/service_workers/index.md Outdated Show resolved Hide resolved
skyclouds2001 and others added 2 commits May 18, 2024 16:52
@skyclouds2001 @wbamberg
Apply suggestions from code review
7a36d2f 
Co-authored-by: wbamberg <will@bootbonnet.ca>
@skyclouds2001
update example
b787dc7
wbamberg
wbamberg approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @skyclouds2001 !

@wbamberg wbamberg merged commit 2e32784 into mdn:main May 18, 2024
9 checks passed
@skyclouds2001 skyclouds2001 deleted the caches branch May 18, 2024 18:17
yin1999 added a commit to mdn/translated-content that referenced this pull request May 19, 2024
@yin1999
zh-cn: resolve global properties caches
5d5b008 
ref: mdn/content#33359
yin1999 added a commit to mdn/translated-content that referenced this pull request May 19, 2024
@yin1999
zh-cn: resolve global properties caches
1da6dc3 
ref: mdn/content#33359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@pepelsbey pepelsbey Awaiting requested review from pepelsbey pepelsbey is a code owner automatically assigned from mdn/core-yari-content

Assignees
No one assigned
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:PWA Progressive Web Apps content Content:WebAPI Web API docs size/m 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skyclouds2001 @wbamberg