Fix container dimensions #33447
Merged
Fix container dimensions #33447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a spacing issue observed when looking at the full Pacman canvas. The new dimension values chosen are not random, they were calculated so that: - The spacing on the x- and y-axis between the inner and outer container rectangles are the same. - The spacing on the x- and y-axis between the inner container rectangle and the nearest object (pacman and 2 inner rectangles) are the same. It additionally adjusts the height of the canvas so the full image can be in-view.
|
Preview URLs (comment last updated: 2024-06-09 19:56:54) |
Josh-Cena
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a spacing issue observed when looking at the full Pacman canvas.
The new dimension values chosen are not random, they were calculated so that:
It additionally adjusts the height of the canvas so the full image can be in-view.
Before:
After:
Disclaimer:
The image on the site looks like this:
Which looks OK but I suspect it has been intentionally cropped to due to the dimension misalignment? Or is that not the case?
See https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Drawing_shapes#making_combinations for more details.