Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize with BCD v5.5.26 #33483

Merged
merged 1 commit into from
May 8, 2024
Merged

Synchronize with BCD v5.5.26 #33483

merged 1 commit into from
May 8, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner May 8, 2024 00:28
@OnkarRuikar OnkarRuikar requested review from wbamberg and removed request for a team May 8, 2024 00:28
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels May 8, 2024
@sideshowbarker sideshowbarker merged commit 95036ee into mdn:main May 8, 2024
7 checks passed
@OnkarRuikar OnkarRuikar deleted the sync_bcd branch May 8, 2024 04:08
@bsmth
Copy link
Member

bsmth commented May 8, 2024

@OnkarRuikar it looks like the automated pr label is missing, is your script able to add this (are you using gh CLI/API)? 🤔

dalps pushed a commit to dalps/content that referenced this pull request May 8, 2024
Co-authored-by: OnkarRuikar <OnkarRuikar@users.noreply.github.com>
@OnkarRuikar
Copy link
Contributor Author

@OnkarRuikar it looks like the automated pr label is missing, is your script able to add this (are you using gh CLI/API)? 🤔

I am using following command in the script:

 gh pr create --title "Synchronize with BCD $VERSION" --body "$pr_body" --repo "mdn/content" --label "automated pr"

It could be a permission issue. I'll try to create a PR in mdn/content from local dev environment using the same command.

@bsmth
Copy link
Member

bsmth commented May 10, 2024

It could be a permission issue. I'll try to create a PR in mdn/content from local dev environment using the same command.

Yeah it looks like it should work. A similar command works for me in a personal repo using that format:

gh pr create --title "Test PR" --body "test" --repo "bsmth/test-repo" --label "automated pr"

@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented May 11, 2024

gh pr create --title "Test PR" --body "test" --repo "bsmth/test-repo" --label "automated pr"

You have all the rights to your own repos so you can put label using the command.

This is a permission issue. I do not have admin rights to mdn/content repo so label is not getting added. To test I've created a PR in mdn/content repo using the command:

fsh$ gh pr create --title "fix a broken link flaw" --body "We should avoid preemptively creating links to future docs." --repo "mdn/content" --label "automated pr"
? Where should we push the 'fix_flaw' branch? OnkarRuikar/content

Creating pull request for OnkarRuikar:fix_flaw into main in mdn/content

remote: 
remote: 
To github.com:OnkarRuikar/content.git
 * [new branch]            HEAD -> fix_flaw
Branch 'fix_flaw' set up to track remote branch 'fix_flaw' from 'origin'.
https://github.com/mdn/content/pull/33548
pull request update failed: GraphQL: OnkarRuikar does not have permission to update the pull request PR_kwDOEaEoos5vJeVo. (updatePullRequest)
content on  fix_flaw  o/  took 28s 

The command failed to add the label. But it did create a PR without the label though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants