Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to trap in the Wasm spec #33571

Merged
merged 6 commits into from
May 14, 2024

Conversation

nataliaschlebinger
Copy link
Contributor

Description & Motivation

The link I'm changing is labeled trap, so it should probably link to the section of the same name, like the line in the same article

Indicates an error during module instantiation (besides traps from the start function).

but currently links to the execution article.

@nataliaschlebinger nataliaschlebinger requested a review from a team as a code owner May 12, 2024 22:47
@nataliaschlebinger nataliaschlebinger requested review from dipikabh and removed request for a team May 12, 2024 22:47
@nataliaschlebinger nataliaschlebinger changed the title Fix link to "trap" in the Wasm spec Fix link to trap in the Wasm spec May 12, 2024
@github-actions github-actions bot added Content:wasm WebAssembly docs size/xs 0-5 LoC changed labels May 12, 2024
Copy link
Contributor

github-actions bot commented May 12, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/WebAssembly/JavaScript_interface
Title: WebAssembly

(comment last updated: 2024-05-14 03:57:06)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! Thanks @nataliaschlebinger 👍

@dipikabh dipikabh merged commit bc6e598 into mdn:main May 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:wasm WebAssembly docs size/xs 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants