-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importmap integrity section #33712
Importmap integrity section #33712
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Preview URLs (comment last updated: 2024-05-22 13:37:34) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yoavweiss, this looks great. I just had a few language suggestions for you to look over, but nothing major.
Question — have you submitted a corresponding https://github.com/mdn/browser-compat-data PR for this? It would be good to list it as a subfeature in the compat table.
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
I put together an initial PR, but it seems like it needs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, nice work @yoavweiss. I did a couple of further small language fixes, and now I think its GTG.
I'll leave it unmerged until we've got the compat data sorted out.
Sounds good, thanks! :) |
Compat data is good to go (I think) at mdn/browser-compat-data#23153 |
Great; I've merged the BCD. Now we just need to wait until the BCD update is slurped into MDN, which usually only takes a day, I think. OR, we could just merge this now, if you don't mind a small risk that it might show without any BCD or spec table for a very short while. |
No strong opinion, so I'll leave the decision up to you! :) |
Let's dooooooooo it ;-) |
Description
SRI support for ES module imports would enable using them in documents that require SRI for certain scripts for security or privacy reasons.
See problem statement and proposal by @guybedford.
This PR adds a description of the added section, to help developers make use of it.
whatwg/html#10269
Chromium CL + tests
WebKit PR
Motivation
Document the newly added
integrity
section in import maps.Additional details
Related issues and pull requests
Fixes mdn/mdn#541