Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 33615 #33720

Merged
merged 8 commits into from
May 24, 2024
Merged

Fix issue 33615 #33720

merged 8 commits into from
May 24, 2024

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented May 22, 2024

Fixes #33615.

As #33615 requested, this adds an entry for "identity provider" and also some related terms. I never know how much detail we should go into in glossary entries versus guide pages - I could imagine we might want to extract some of the "federated identity" page and perhaps the "salt" page into separate guide pages, when we come around to writing them.

I spent too long trying to draw some diagrams for the federated identity one, before deciding it was to much for the page (not to mention having a bad time with drawing tools in general and SVGs in particular).

@hamishwillee , @chrisdavidmills I wonder if either of you would care to look at this?

@github-actions github-actions bot added Content:Glossary Glossary entries size/m [PR only] 51-500 LoC changed labels May 22, 2024
Copy link
Contributor

github-actions bot commented May 22, 2024

Preview URLs

External URLs (4)

URL: /en-US/docs/Glossary/Salt
Title: Salt


URL: /en-US/docs/Glossary/Federated_identity
Title: Federated identity

(comment last updated: 2024-05-24 18:43:52)

@wbamberg wbamberg marked this pull request as ready for review May 22, 2024 17:56
@wbamberg wbamberg requested a review from a team as a code owner May 22, 2024 17:56
@wbamberg wbamberg requested review from chrisdavidmills and removed request for a team May 22, 2024 17:56
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few grammar nits.

files/en-us/glossary/federated_identity/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/federated_identity/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/federated_identity/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/relying_party/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/salt/index.md Outdated Show resolved Hide resolved
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@wbamberg wbamberg merged commit e63979c into mdn:main May 24, 2024
8 checks passed
@hamishwillee
Copy link
Collaborator

Looks excellent. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a glossary entry for "federated identity provider"
3 participants