Fix broken code example in “Managing screen orientation” #33742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashish-CodeJourney
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
files/en-us/web/api/css_object_model/managing_screen_orientation/index.md
Outdated
Show resolved
Hide resolved
sideshowbarker
changed the title
|
Ashish, great work catching and fixing this, and congrats on landing your first docs change here — welcome aboard 🎉 |
Josh-Cena
added a commit
that referenced
this pull request
May 31, 2024
* fix analogy for chained promises * rewrites --------- Co-authored-by: Ashish Vaghela <ashish.vaghela@egreycell.com> Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An example given in the api shows:
screen.addEventListener("orientationchange", () => { console.log(The orientation of the screen is: ${screen.orientation}); });
The correct version should be:
screen.orientation.addEventListener("orientationchange", () => { console.log(The orientation of the screen is: ${screen.orientation}); });
the previous information was slight wrong
event type ("change") for listening to orientation changes on the screen.orientation object and accesses the type property of screen.orientation to log the orientation information accurate
Additional details
Related issues and pull requests