Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33994 basic at scope ff release #34268

Merged
merged 6 commits into from
Jun 24, 2024

Conversation

dletorey
Copy link
Contributor

Description

Added Firefox experimental release note for @scope at-rule

Motivation

Working on MDN issue 33994

Related issues and pull requests

@dletorey dletorey requested a review from a team as a code owner June 19, 2024 11:16
@dletorey dletorey requested review from Elchi3 and removed request for a team June 19, 2024 11:16
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed labels Jun 19, 2024
Copy link
Contributor

github-actions bot commented Jun 19, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2024-06-21 06:52:24)

@dletorey dletorey requested a review from dipikabh June 19, 2024 13:10
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dletorey! I've added a few suggestions.

Two additional points:

  • About the position of this note in the Experimental features > CSS section, I believe you added it after another at-rule entry. The sorting of some other entries still needs to be fixed. But my understanding is that we're ordering them by release. So the @scope entry can be moved to the very end of the CSS section.
  • This update will need a corresponding entry in the Experimental web features section on the 128 release notes page.

dletorey and others added 2 commits June 21, 2024 07:50
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dipikabh dipikabh merged commit 0508613 into mdn:main Jun 24, 2024
8 checks passed
@dletorey dletorey deleted the 33994-basic-at-scope-ff-release branch July 3, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants