Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ff128 Blob.bytes() supported #34310

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Conversation

hamishwillee
Copy link
Collaborator

FF128 supports Blob.bytes() in https://bugzilla.mozilla.org/show_bug.cgi?id=1896475. This adds docs for it and a release note.

Related docs work can be tracked in #33991

@hamishwillee hamishwillee requested review from a team as code owners June 21, 2024 06:39
@hamishwillee hamishwillee requested review from sideshowbarker and removed request for a team June 21, 2024 06:39
@github-actions github-actions bot added Content:WebAPI Web API docs Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed labels Jun 21, 2024
Copy link
Contributor

github-actions bot commented Jun 21, 2024

Preview URLs

Flaws (2)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Blob/bytes
Title: Blob: bytes() method
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.Blob.bytes

URL: /en-US/docs/Mozilla/Firefox/Releases/128
Title: Firefox 128 for developers
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/MediaKeys/getStatusForPolicy does not exist
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/128
Title: Firefox 128 for developers

(comment last updated: 2024-06-24 00:14:58)

@bsmth bsmth requested review from bsmth and removed request for a team June 21, 2024 07:43
@bsmth
Copy link
Member

bsmth commented Jun 21, 2024

BTW, Yari complains about {{domxref("Uint8Array")}} "(consider changing which macro you use)".

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Thanks, Hamish

@sideshowbarker sideshowbarker removed their request for review June 21, 2024 17:46
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jun 21, 2024
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jun 24, 2024
@hamishwillee
Copy link
Collaborator Author

Thanks very much for the review @bsmth - I fixed up the typed array instances to jsxref (good catch) - link previously worked and I didn't look carefully at the errors :-0

@hamishwillee hamishwillee merged commit 55dc6f0 into mdn:main Jun 24, 2024
8 checks passed
@bsmth
Copy link
Member

bsmth commented Jun 24, 2024

Thanks, Hamish!

@hamishwillee hamishwillee deleted the ff128_blob_bytes branch June 25, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants