Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update support for installing non-PWA sites #34336

Merged
merged 4 commits into from
Jul 7, 2024
Merged

Update support for installing non-PWA sites #34336

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3540c94
Update support for installing non-PWA sites
FormularSumo Jun 21, 2024
cbf4fd0
Non-PWA sites can't be installed on any iOS browsers
FormularSumo Jun 21, 2024
e4c855c
Safari supports PWA installation, Firefox with an extension
FormularSumo Jun 21, 2024
fd0af8c
Apply suggestions
FormularSumo Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions files/en-us/web/progressive_web_apps/guides/making_pwas_installable/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ Support for PWA installation promotion from the web varies by browser and by pla

On desktop:

- Firefox and Safari do not support installing PWAs on any desktop operating systems. See [Installing sites as apps](#installing_sites_as_apps), below.
- Chrome and Edge support installing PWAs on Linux, Windows, macOS, and Chromebooks.
- Chrome, Edge & Safari support installing PWAs on all supported desktop operating systems.
- Firefox only supports installing PWAs on desktop with an [unofficial extension](https://addons.mozilla.org/en-US/firefox/addon/pwas-for-firefox/).
FormularSumo marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

@wbamberg wbamberg Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I like the reference to the Firefox extension. It's not official (as you say) or very widely used, and I'm not sure how referencing it really helps web developers. And it gives the docs a chance to be out of date or even dangerous if the extension stops getting support or turns out to have problems.

IMO we should just say it's not supported by Firefox.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbamberg Yes ^^^.

Note, I haven't given up on reviewing this, just trying to clear my FF release stuff first. Feel free to update and merge it as you like, because I'm still trudging through the list.

What I want to do with this is the work to more loosely define what a PWA is and better capture app installability options. But those are bigger jobs.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't think we should list Safari as "supports installing PWAs". Safari support for installing sites is exactly what #30875 was designed to accommodate (see also #30463 (comment)), and I don't see any good reason to reconsider this here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I proposed a fix above.

The separate concepts we want to capture are manifest installation and app installation - a PWA can use either, but the manifest provides the best app-like experience.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what's in the page now is entirely correct and reflects the "model" of the docs that the authors had in mind. I don't think any actual new information has emerged wrt Safari (i.e. we already knew that Safari supported installing any site) and what is/was known is already explicitly accommodated in the page. So I think we should leave it as is.

Firefox and Safari do not support installing PWAs on any desktop operating systems. See Installing sites as apps, below.
...

Safari for desktop and mobile, and Edge for desktop also support installing any website as an app. However, this is not specific to PWA because the site doesn't need to meet the installability criteria described in this guide, and because the browser doesn't proactively promote the site for installation.

I don't know what the point is of adding more hedging about the manifest in here. But, I won't argue about it any more if you think it should be in. As i said already, I don't think arguing about exactly what defines a PWA is very productive.

Copy link
Collaborator

@hamishwillee hamishwillee Jul 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly enough to make modifications the way I'd like without support. I'm OK to close the whole PR.

Though we should do this bit https://github.com/mdn/content/pull/34336/files#r1650338836 - since Chrome now supported for apps as well.


On mobile:

Expand All @@ -121,7 +121,7 @@ On mobile:

### Installing sites as apps

Safari for desktop and mobile, and Edge for desktop also support installing any website as an app. However, this is not specific to PWA because the site doesn't need to meet the installability criteria described in this guide, and because the browser doesn't proactively promote the site for installation.
Chrome for desktop and Android, Safari for desktop, and Edge for desktop also support installing any website as an app. However, this is not specific to PWA because the site doesn't need to meet the installability criteria described in this guide, and because the browser doesn't proactively promote the site for installation.
FormularSumo marked this conversation as resolved.
Show resolved Hide resolved

### Triggering the install prompt

Expand Down