Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arrow function documentation to clarify naming and assignment #34501

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

mathdebate09
Copy link
Contributor

Description

Update the previous sentence formation as per discussions in the issue.

Motivation

The current sentence phrasing is confusing, improving it will make it somewhat straightforward.

Additional details

nil

Related issues and pull requests

Fixes #34488

@mathdebate09 mathdebate09 requested a review from a team as a code owner June 29, 2024 07:03
@mathdebate09 mathdebate09 requested review from Josh-Cena and removed request for a team June 29, 2024 07:03
@github-actions github-actions bot added Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed labels Jun 29, 2024
Copy link
Contributor

github-actions bot commented Jun 29, 2024

Preview URLs

(comment last updated: 2024-06-29 14:29:03)

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thank you!

@Josh-Cena Josh-Cena merged commit 23013cf into mdn:main Jun 29, 2024
8 checks passed
@mathdebate09
Copy link
Contributor Author

🚀

@mathdebate09 mathdebate09 deleted the arrow_references_update branch June 29, 2024 14:50
wbamberg added a commit to wbamberg/content that referenced this pull request Jun 29, 2024
* upstream/main: (58 commits)
  Update arrow function documentation to clarify naming and assignment (mdn#34501)
  update fetch guide (mdn#34278)
  Replace alert in Learn/JavaScript/First_steps/Variables (mdn#34487)
  Replace alert in MDN/Writing_guidelines/Page_structures/Live_samples (mdn#34479)
  Fix typo (mdn#34486)
  Remove SVG color-profile attribute (mdn#34482)
  Remove SVG enable-background attribute (mdn#34483)
  Remove SVG kerning attribute (mdn#34475)
  Updated the description of `targetOrigin`  to specify the intended re… (mdn#34114)
  Mention CSWH in WebSocket server guide (mdn#34411)
  Add note to CSP sandbox saying allow-top-navigation is redundant (mdn#34415)
  Mention navigator.languages may be truncated and Accept-Language may have fallback (mdn#34418)
  Remove IDB output "example", preferring live example (mdn#34464)
  Mention that pinch-zoom are also wheel events (mdn#34468)
  Mention that flex-basis is floored at min-content (mdn#34469)
  More content to Global object glossary (mdn#34471)
  Fix IDB cursor prev direction description (mdn#34463)
  Remove all line number references to inline code examples (mdn#34459)
  Remove link to notification example (mdn#34412)
  Replaces HTML entity glossary links/mentions with char reference (mdn#34391)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change use of "has a name" for arrow functions which are "always unnamed"
2 participants