FF88 - FTP disabled by default on all releases #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
requested review from
chrisdavidmills
and removed request for
a team
chrisdavidmills
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
LGTM @hamishwillee !
Yeah, the table does read slightly odd because of this, but I guess you need it think of it as "version this change was added". There's no hard rule hre, and I wouldn't mind at all if you changed it to "version disabled"
This was referenced Mar 29, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Experimental features > FTP support disabled to note that FTP is disabled on all builds from FF88. This follows https://bugzilla.mozilla.org/show_bug.cgi?id=1691890
Note the table is a little odd because we normally have table headers "version added" and "enabled by default" but for removal of features perhaps should be "version disabled", "disabled by default". I don't know if there is a precedent for this so I didn't change it. Open to doing so, but doesn't seem worth it for 2 releases before this disappears forever.