Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archiving HTML - Using the Application cache #4016

Merged
merged 2 commits into from Apr 12, 2021

Conversation

SphinxKnight
Copy link
Member

@SphinxKnight SphinxKnight commented Apr 11, 2021

What was wrong/why is this fix needed? (quick summary only)

After reviewing /docs/Web/HTML/Using_the_application_cache for a French PR, I decided it would be better to archive this page since Firefox and Chrome removed it:

https://developers.google.com/web/updates/2020/07/chrome-85-deps-rems
https://bugzilla.mozilla.org/show_bug.cgi?id=1619673

MDN URL of main page changed

https://developer.mozilla.org/en-US/docs/Web/HTML/Using_the_application_cache

Issue number (if there is an associated issue)

Anything else that could help us review it

See corresponding PRs on mdn/archived-content and mdn/translated-content
mdn/archived-content#12
mdn/translated-content#477

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachelandrew I still don't understand the MDN archiving policy, but this sounds like a good idea to me (so I have marked as "approved).

@SphinxKnight Do you think it is worth applying also to the associated reference docs too?

@sideshowbarker
Copy link
Collaborator

Is the CI failure a https://github.com/mdn/content/pull/4016/checks?check_run_id=2317502157 expected?

Run yarn content validate-redirects en-us --strict
yarn run v1.22.10
$ env-cmd --silent cross-env CONTENT_ROOT=files node node_modules/@mdn/yari/tool/cli.js validate-redirects en-us --strict
removing orphaned redirect (to doesn't exists): /en-US/docs/HTML/Using_the_application_cache	/en-US/docs/Web/HTML/Using_the_application_cache
removing orphaned redirect (to doesn't exists): /en-US/docs/Offline_resources_in_Firefox	/en-US/docs/Web/HTML/Using_the_application_cache
removing orphaned redirect (to doesn't exists): /en-US/docs/Using_Application_Cache	/en-US/docs/Web/HTML/Using_the_application_cache
removing orphaned redirect (to doesn't exists): /en-US/docs/Using_the_Application_Cache	/en-US/docs/Web/HTML/Using_the_application_cache
info: _redirects.txt for en-us is causing issues: Error:  _redirects.txt for en-us is flawed

@SphinxKnight
Copy link
Member Author

Is the CI failure a https://github.com/mdn/content/pull/4016/checks?check_run_id=2317502157 expected?

Run yarn content validate-redirects en-us --strict
yarn run v1.22.10
$ env-cmd --silent cross-env CONTENT_ROOT=files node node_modules/@mdn/yari/tool/cli.js validate-redirects en-us --strict
removing orphaned redirect (to doesn't exists): /en-US/docs/HTML/Using_the_application_cache	/en-US/docs/Web/HTML/Using_the_application_cache
removing orphaned redirect (to doesn't exists): /en-US/docs/Offline_resources_in_Firefox	/en-US/docs/Web/HTML/Using_the_application_cache
removing orphaned redirect (to doesn't exists): /en-US/docs/Using_Application_Cache	/en-US/docs/Web/HTML/Using_the_application_cache
removing orphaned redirect (to doesn't exists): /en-US/docs/Using_the_Application_Cache	/en-US/docs/Web/HTML/Using_the_application_cache
info: _redirects.txt for en-us is causing issues: Error:  _redirects.txt for en-us is flawed

No it's not, I realized I didn't use yarn content as appropriate. Will fix that (and check locally before pushing here)

@SphinxKnight SphinxKnight requested a review from a team as a code owner April 12, 2021 05:34
@SphinxKnight SphinxKnight requested review from chrisdavidmills and removed request for a team April 12, 2021 05:34
@SphinxKnight
Copy link
Member Author

Do you think it is worth applying also to the associated reference docs too?

Well, as this is my first "archiving" set of PRs and since it originated from a review on HTML docs, I intended to leave other material about AppCache for another PR.

Let me know if you think it's best to put them all in the same basket.

@sideshowbarker
Copy link
Collaborator

Well, as this is my first "archiving" set of PRs and since it originated from a review on HTML docs, I intended to leave other material about AppCache for another PR.

OK, given that @hamishwillee already approved this, it seems like let’s go ahead and land it — and any further work can be done in follow-up PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants